-
Notifications
You must be signed in to change notification settings - Fork 126
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
data-sort
attributes to dataTables rows to support date sort
Adding a `data-sort` with ISO 8601 datetimes allows dataTables to sort independent of the visible row values. We continue to use javascript to generate the human-readable time for the reasons given in #1416 (support for page caching). We sort to `#iso8601(5)` (i.e. to 5 decimal places). This still allows a mismatch between displayed times and correctly sorted times (off by one second), apparently due to rounding behavior in the javascript sort dates. The actual dates sort correctly, so display dates sort themselves out (ha!) as a notification ages past one minute. Fixes #1653.
- Loading branch information
Tom Johnson
committed
Mar 1, 2018
1 parent
7c30272
commit 7309f6e
Showing
4 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters