Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end sorting only takes into account objects on page #2858

Closed
no-reply opened this issue Mar 28, 2018 · 2 comments
Closed

Front-end sorting only takes into account objects on page #2858

no-reply opened this issue Mar 28, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@no-reply
Copy link
Contributor

Descriptive summary

Throughout the application (e.g. on the Notifications page), we have data tables that support sorting. Some behavioral problems with that sorting were fixed in #2741, but they still take into account only the objects actually loaded into the tables. Sorting, e.g. notifications by date , sorts the 10 objects loaded onto the page, but does not provide the most/least recent notifications system wide.

Rationale

Users expect sorting to take into account all of the relevant objects.

Expected behavior

Notifications (and other sorting tables) should display the appropriate objects in the requested order. New objects should display on the page when the sort order changes.

Actual behavior

Notifications (and other sorting tables) display only the objects already on the page.

Steps to reproduce the behavior

  1. Generate more than 10 notifications for a user
  2. Log in as the user
  3. Visit /notifications
  4. Take note of which notifications are displayed
  5. Click the sort icon to the right of the Date column to change the order
  6. Observe that the same 10 notifications display as before

Related work

Related to #1653; #2741.

@rjkati
Copy link

rjkati commented Jan 27, 2021

Unable to replicate in Hyrax 3.0.0 rc3 in either Chrome 87.0.4280.141 or Firefox 85.0 @jlhardes

@jlhardes
Copy link
Contributor

Thanks @rjkati! Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants