Merge master #2116
Merged
Merge master #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 5, 2017
| .dropdown-toggle:focus { | ||
| outline: 2px auto Highlight; // FireFox | ||
| outline: 5px auto -webkit-focus-ring-color; // Chrome, Safari | ||
| outline: -2px; |
There was a problem hiding this comment.
Property outline already defined on line 25
|
|
||
| .dropdown-toggle:focus { | ||
| outline: 2px auto Highlight; // FireFox | ||
| outline: 5px auto -webkit-focus-ring-color; // Chrome, Safari |
There was a problem hiding this comment.
Property outline already defined on line 25
| @@ -20,6 +20,10 @@ legend small { | |||
| } | |||
| } | |||
|
|
|||
| #savewidget a { | |||
houndci-bot
reviewed
Nov 5, 2017
| .dropdown-toggle:focus { | ||
| outline: 2px auto Highlight; // FireFox | ||
| outline: 5px auto -webkit-focus-ring-color; // Chrome, Safari | ||
| outline: -2px; |
There was a problem hiding this comment.
Property outline already defined on line 25
|
|
||
| .dropdown-toggle:focus { | ||
| outline: 2px auto Highlight; // FireFox | ||
| outline: 5px auto -webkit-focus-ring-color; // Chrome, Safari |
There was a problem hiding this comment.
Property outline already defined on line 25
| @@ -20,6 +20,10 @@ legend small { | |||
| } | |||
| } | |||
|
|
|||
| #savewidget a { | |||
ee1974f to
6ad7057
Compare
Set the (overrideable) theme to be used in the work and collection controlers, and use the 1_column layout to pick up the controls navbar. Fixes samvera-labs/nurax-pre2023#71
Else, clicking "Review Submissions" in Dashboard throws error -- ActionView::Template::Error (RSolr::Error::Http - 414 Request-URI Too Long) -- if the number of workflows in the system is large enough to make the GET request's query string longer than Solr can handle. Note that this solution requires ActiveFedora 11.5.0, though this code does not break with 11.4.1; it passes an argument that AF < 11.5.0 ignores. Fixes #1875
Updates the requirements on [rails-controller-testing](https://github.com/rails/rails-controller-testing) to permit the latest version.
This is an innovation in place in more than one Sufia/Hyrax application downstream that makes derivatives work as expected.
This actor assigned a variable to `nil`, then acted only `if variable`. It then called `save` on the object, making it expensive and leading to potential surprising impact on other actors. This removes it from the actor stack and deletes the actor file.
Fixes #1455 * Stop caring about hash keys in workflow notifications * Admin Set Managers should be granted all registered roles on an active workflow, not just approving * Fix bug with `#grant_workflow_roles` that prevents creating a new corresponding workflow role when switching workflows * Scope PermissionQuery#scope_users_for_entity_and_roles to the entity's workflow * Disentangle PermissionTemplateForm#update_management
References samvera-labs/nurax-pre2023#96 Fixes #1742 With the refactoring of collection controllers to create two collection show pages (public and dashboard), someone given editor rights to a collection no longer has a way to get to the editing view. This change adds the actions onto the public show page to restore this feature until the collections sprint work is completed.
…ates the need for most of the accompanying CSS.
ghost
approved these changes
Nov 9, 2017
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.