Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Menu appears on File View page but not on other pages #71

Closed
julesies opened this issue Sep 28, 2017 · 4 comments
Closed

Menu appears on File View page but not on other pages #71

julesies opened this issue Sep 28, 2017 · 4 comments
Labels
MustFix for Release

Comments

@julesies
Copy link
Collaborator

Descriptive summary

When looking at the File View in Chrome, you see a menu that is not seen on other pages.

screen shot 2017-09-28 at 9 28 20 am

Rationale

It should be consistent. FWIW I like seeing the menu and think it would help with navigation.

Steps to reproduce the behavior

1: https://nurax.curationexperts.com/concern/parent/sb397824g/file_sets/hd76s004z
@julesies julesies changed the title Menu appears on File View page but nothing else Menu appears on File View page but not on other pages Sep 28, 2017
@mjgiarlo
Copy link
Member

@julesies What menu? Can't tell from screenshot or description above what menu you're referring to.

@julesies
Copy link
Collaborator Author

@mjgiarlo sorry for any confusion. I'm talking about the top left menu under Hyrax. Home, about, menu, contact.

Looks like it's also on the Search page, but not on work view or collection view.

screen shot 2017-09-29 at 8 31 39 am

@julesies
Copy link
Collaborator Author

@mjgiarlo @vantuyls did we mean to mark this fix in 2.0? I think I dropped the ball on this one if so.

@mjgiarlo
Copy link
Member

@julesies @vantuyls I have a fix almost ready. Will push a PR this week.

mjgiarlo added a commit to samvera/hyrax that referenced this issue Oct 12, 2017
@mjgiarlo
Render controls navbar in work and collection show views
c3c25e6 
Set the (overrideable) theme to be used in the work and collection controlers, and use the 1_column layout to pick up the controls navbar.

Fixes samvera-labs/nurax-pre2023#71
@mjgiarlo mjgiarlo mentioned this issue Oct 12, 2017
Merged
mjgiarlo added a commit to samvera/hyrax that referenced this issue Oct 12, 2017
@mjgiarlo
Render controls navbar in work and collection show views
c02f02a 
Set the (overrideable) theme to be used in the work and collection controlers, and use the 1_column layout to pick up the controls navbar.

Fixes samvera-labs/nurax-pre2023#71
jcoyne pushed a commit to samvera/hyrax that referenced this issue Nov 6, 2017
@mjgiarlo @jcoyne
Render controls navbar in work and collection show views
05b1285 
Set the (overrideable) theme to be used in the work and collection controlers, and use the 1_column layout to pick up the controls navbar.

Fixes samvera-labs/nurax-pre2023#71
jcoyne pushed a commit to samvera/hyrax that referenced this issue Nov 6, 2017
@mjgiarlo @jcoyne
Render controls navbar in work and collection show views
f4eb4b6 
Set the (overrideable) theme to be used in the work and collection controlers, and use the 1_column layout to pick up the controls navbar.

Fixes samvera-labs/nurax-pre2023#71
jcoyne pushed a commit to samvera/hyrax that referenced this issue Nov 9, 2017
@mjgiarlo @jcoyne
Render controls navbar in work and collection show views
690c41b 
Set the (overrideable) theme to be used in the work and collection controlers, and use the 1_column layout to pick up the controls navbar.

Fixes samvera-labs/nurax-pre2023#71
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
MustFix for Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjgiarlo @julesies