Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User with Editor role can't see private collection #1742

Closed
VivianChu opened this issue Sep 28, 2017 · 5 comments
Closed

User with Editor role can't see private collection #1742

VivianChu opened this issue Sep 28, 2017 · 5 comments
Assignees
Labels
blocker bug Collection impacts the Collection part of PCDM Model
Milestone

Comments

@VivianChu
Copy link
Contributor

Descriptive summary

For Hyrax 2.0.0.beta1, User with Editor role can't see a private collection created by other Users.
For Hyrax 2.0.0.alpha, Editor user can see private collection fine.

Hyrax 2.0.0.beta1
editordashboard

privatecollection

For Hyrax 2.0.0.alpha
beforeeditordashboard

beforeprivatecollection

Rationale

To have same editor function as previous hyrax version.

Expected behavior

Editor User can see private collection created by Admin or other Users.

Actual behavior

Editor User can't see private collection.

Steps to reproduce the behavior

  1. Log in as admin
  2. Create a new collection, select private visibility
  3. Log out
  4. Log in as editor
  5. Go to Dashboard: Collections: All collections
  6. Click on a new collection created by admin user
  7. Should see message "You are not authorized to access this page"
@mjgiarlo
Copy link
Member

mjgiarlo commented Oct 4, 2017

Fixed by #1760

@mjgiarlo mjgiarlo closed this as completed Oct 4, 2017
@mjgiarlo mjgiarlo removed the ready label Oct 4, 2017
@mjgiarlo
Copy link
Member

This only fixed the behavior for administrative users. Reopening.

@mjgiarlo mjgiarlo reopened this Oct 26, 2017
@mjgiarlo
Copy link
Member

Refs samvera-labs/nurax-pre2023#96

@laritakr laritakr self-assigned this Oct 26, 2017
@elrayle
Copy link
Contributor

elrayle commented Oct 27, 2017

Hyrax 1.0 - 2.0.0.rc1

In Hyrax 2.0, you cannot see collections you did not create through Dashboard -> Collections -> Your Collections. I am fairly certain that has been the case for all releases (alpha - beta - rc) of Hyrax. In Sufia, you could see collections shared with you on the 'Shared with me' tab.

In your steps to reproduce, you reference the All Collections tab. That tab is only shown to admin users. Perhaps your expectation that this used to work in alpha was because the test was done with an editor who was also an admin user.

Hyrax collections-sprint branch

In collections-sprint branch, we have added an additional Managed Collections tab to Dashboard -> Collections. On that tab, you see collections for which you were granted :manage, :deposit, or :view access. Users will be able to view the admin show page for a collection if they have any of these access levels granted.

@elrayle
Copy link
Contributor

elrayle commented Oct 27, 2017

FYI... works have the same issue where there is no way to see works shared with you through Dashboard -> Works

FYI... There were previous discussions about incorporating Managed Collections and Managed Works into Hyrax 2.0 branch, but the consensus at the time was not to include it as it was too much new work and we were very close to a 2.0 release. This will be fixed in 2.1 when collections-sprint branch is merged into master.

laritakr pushed a commit that referenced this issue Oct 27, 2017
References samvera-labs/nurax-pre2023#96
Fixes #1742

With the refactoring of collection controllers to create two collection
show pages (public and dashboard), someone given editor rights to a
collection no longer has a way to get to the editing view.

This change adds the actions onto the public show page to restore this
feature until the collections sprint work is completed.
jcoyne pushed a commit that referenced this issue Nov 6, 2017
References samvera-labs/nurax-pre2023#96
Fixes #1742

With the refactoring of collection controllers to create two collection
show pages (public and dashboard), someone given editor rights to a
collection no longer has a way to get to the editing view.

This change adds the actions onto the public show page to restore this
feature until the collections sprint work is completed.
jcoyne pushed a commit that referenced this issue Nov 6, 2017
References samvera-labs/nurax-pre2023#96
Fixes #1742

With the refactoring of collection controllers to create two collection
show pages (public and dashboard), someone given editor rights to a
collection no longer has a way to get to the editing view.

This change adds the actions onto the public show page to restore this
feature until the collections sprint work is completed.
jcoyne pushed a commit that referenced this issue Nov 9, 2017
References samvera-labs/nurax-pre2023#96
Fixes #1742

With the refactoring of collection controllers to create two collection
show pages (public and dashboard), someone given editor rights to a
collection no longer has a way to get to the editing view.

This change adds the actions onto the public show page to restore this
feature until the collections sprint work is completed.
jcoyne pushed a commit that referenced this issue Nov 9, 2017
References samvera-labs/nurax-pre2023#96
Fixes #1742

With the refactoring of collection controllers to create two collection
show pages (public and dashboard), someone given editor rights to a
collection no longer has a way to get to the editing view.

This change adds the actions onto the public show page to restore this
feature until the collections sprint work is completed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Collection impacts the Collection part of PCDM Model
Projects
None yet
Development

No branches or pull requests

4 participants