[WIP] Valkyrie #1777
Closed
[WIP] Valkyrie #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e69fc02 to
c85a2e1
Compare
jeremyf
reviewed
Oct 11, 2017
| @@ -58,6 +56,16 @@ def apply_order(curation_concern, new_order) | |||
| curation_concern.list_source.order_will_change! | |||
| true | |||
| end | |||
|
|
|||
| def find_resource(id) | |||
| query_service.find_by(id: Valkyrie::ID.new(id.to_s)) | |||
There was a problem hiding this comment.
This looks like Valkyrie should be responsible for casting the given id to a Valkyrie:ID. This method does not know that the given query_service is Valkyrie. As such I believe the find_by method in Valkyrie should be responsible for casting to an id.
Adjust the DynamicChangeSet to namespace for Hyrax classes
Refactor count queries away from ActiveFedora::Relation
…into ProxyDepositRequest
Works controller now uses change sets rather than actors
Remove the namespacing from the Change Set
Persist instead of save
Add a CollectionChangeSetPersister
Restore attributes for thumbnail and representative
Convert batch forms to ChangeSets
…ates the need for most of the accompanying CSS.
Merge master
houndci-bot
reviewed
Nov 9, 2017
| .dropdown-toggle:focus { | ||
| outline: 2px auto Highlight; // FireFox | ||
| outline: 5px auto -webkit-focus-ring-color; // Chrome, Safari | ||
| outline: -2px; |
There was a problem hiding this comment.
Property outline already defined on line 25
|
|
||
| .dropdown-toggle:focus { | ||
| outline: 2px auto Highlight; // FireFox | ||
| outline: 5px auto -webkit-focus-ring-color; // Chrome, Safari |
There was a problem hiding this comment.
Property outline already defined on line 25
| @@ -20,6 +20,10 @@ legend small { | |||
| } | |||
| } | |||
|
|
|||
| #savewidget a { | |||
houndci-bot
reviewed
Nov 9, 2017
| .dropdown-toggle:focus { | ||
| outline: 2px auto Highlight; // FireFox | ||
| outline: 5px auto -webkit-focus-ring-color; // Chrome, Safari | ||
| outline: -2px; |
There was a problem hiding this comment.
Property outline already defined on line 25
|
|
||
| .dropdown-toggle:focus { | ||
| outline: 2px auto Highlight; // FireFox | ||
| outline: 5px auto -webkit-focus-ring-color; // Chrome, Safari |
There was a problem hiding this comment.
Property outline already defined on line 25
| @@ -20,6 +20,10 @@ legend small { | |||
| } | |||
| } | |||
|
|
|||
| #savewidget a { | |||
Got rid of two views by moving the code to the CollectionsHelper too.
Restore the routing for the BatchUploadChangeSet
Reset permissions via the attributes on work
Use thumbnail_id rather than thumbnail
Pass change_set to views
Cast strings to Valkyrie identifiers
Restore the stubbing of the actor in the WorksController spec
Remove autocreate_fields! it makes it impossible to set required fields
Actor returns the resource on successful update
…2166) include ... order doesn't matter; added 'import_url' foo
|
Closing this in favor of #2178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.