Generic_work_change_set_spec #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Nov 13, 2017
| @@ -362,7 +362,7 @@ | |||
|
|
|||
| # rubocop:disable RSpec/ExampleLength | |||
| it do | |||
| is_expected.to eq ["created_at", "updated_at", "depositor", "title", | |||
| is_expected.to include("created_at", "updated_at", "depositor", "title", | |||
There was a problem hiding this comment.
Can you explain the rationale for this change?
There was a problem hiding this comment.
Per Justin's point, just for fun I switched include to contain_exactly and get an error that import_url is returned, but not expected, so does this reveal a bug?
1) GenericWorkChangeSet#fields should contain exactly "created_at", "updated_at", "depositor", "title", "date_uploaded", "date_modified", "admin_set_id", "state", "proxy_depositor", "on_behalf_of", "arkivo_checksum", "member_of_collection_ids", "member_ids", "thumbnail_id", "representative_id", "label", "relative_path", "resource_type", "creator", "contributor", "description", "keyword", "license", "rights_statement", "publisher", "date_created", "subject", "language", "identifier", "related_url", "source", and "based_near"
Failure/Error:
is_expected.to contain_exactly("created_at", "updated_at", "depositor", "title",
"date_uploaded", "date_modified", "admin_set_id",
"state", "proxy_depositor", "on_behalf_of",
"arkivo_checksum", "member_of_collection_ids",
"member_ids", "thumbnail_id", "representative_id",
"label", "relative_path", "resource_type", "creator",
"contributor", "description", "keyword", "license",
"rights_statement",
"publisher", "date_created", "subject", "language",
"identifier", "related_url", "source", "based_near")
expected collection contained: ["admin_set_id", "arkivo_checksum", "based_near", "contributor", "created_at", "creator", "date_creat...urce_type", "rights_statement", "source", "state", "subject", "thumbnail_id", "title", "updated_at"]
actual collection contained: ["admin_set_id", "arkivo_checksum", "based_near", "contributor", "created_at", "creator", "date_creat...urce_type", "rights_statement", "source", "state", "subject", "thumbnail_id", "title", "updated_at"]
the extra elements were: ["import_url"]
There was a problem hiding this comment.
test fails, so rather than re-order it seemed better to not require order (since order doesn't matter) ... just testing with contains_exactly
|
My commit just fixes some whitespace offenses on rubocop, feel free to squash it into the original commit once the review is complete |
jcoyne
requested changes
Nov 13, 2017
| "rights_statement", | ||
| "publisher", "date_created", "subject", "language", | ||
| "identifier", "related_url", "source", "based_near"] | ||
| is_expected.to include("created_at", "updated_at", "depositor", "title", |
There was a problem hiding this comment.
Is contain_exactly what we want here then?
include ... order doesn't matter; added 'import_url' foo
13b309a to
d1804f6
Compare
|
Looks like this needs a rebase. |
jcoyne
approved these changes
Nov 13, 2017
jcoyne
pushed a commit
that referenced
this pull request
Nov 14, 2017
…2166) include ... order doesn't matter; added 'import_url' foo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one failure where result of eq is not in same order. Order doesn't matter here so use include.