Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remediate Hyrax simple-form error on version 3.5.1 #2665

Closed
laritakr opened this issue Feb 16, 2018 · 5 comments
Closed

Remediate Hyrax simple-form error on version 3.5.1 #2665

laritakr opened this issue Feb 16, 2018 · 5 comments
Assignees
@no-reply @jrgriffiniii
Labels
technical debt
Milestone
2.x series

Comments

@laritakr
Copy link
Contributor

Descriptive summary

Simple-form version 3.5.1 causes build failure.

PR #2663 locks Hyrax's simple-form and parser versions.
@elrayle elrayle mentioned this issue Feb 21, 2018
Closed
@laritakr
Copy link
Contributor Author

laritakr commented Mar 2, 2018

see issue heartcombo/simple_form#1549

@cjcolvar
Copy link
Member

cjcolvar commented Mar 5, 2018

See also samvera/hydra-editor#139

@no-reply no-reply self-assigned this Apr 12, 2018
@no-reply no-reply modified the milestones: 2.x - Analytics - Milestone 1, 2.x series Apr 12, 2018
@no-reply
Copy link
Contributor

See also #2296

@elrayle
Copy link
Contributor

elrayle commented Apr 13, 2018

@no-reply @vantuyls As this has a viable temporary pin, I would recommend targeting a fix for this in 2.1.1.

@no-reply
Copy link
Contributor

Depending on what happens with hydra-editor 3.3.3 and 4.0.0, fixing this may involve a breaking API change in hydra-editor. For that reason, it might not be possible to release a fix in 2.1.1.

I'd like to track it with the 2.1.0 tickets, in hope that a solution will present itself in the next few days; and we don't leave Hyrax 2.1 pinned to a version of simple-form that won't receive bug fixes.

@jrgriffiniii I believe the fix necessary is a release of hydra-editor at 3.3.3, which is already prepared on (https://github.com/samvera/hydra-editor/tree/3-3-stable), followed by a release of 4.0.0, which has an existing RC that has been tested with Hyrax.

no-reply pushed a commit that referenced this issue May 4, 2018
Add support for simple_form 3.5.1 and later
610c6d1 
The pin was initally introduced in #2663. `hydra-editor` now handles pinning of
`simple_form` versions (see: samvera/hydra-editor#143)
on its 3.x series. We support newer versions of `simple_form` via `hydra-editor`
4.x (see: samvera/hydra-editor#145).

Fixes #2665.
@no-reply no-reply mentioned this issue May 4, 2018
Closed
@jrgriffiniii jrgriffiniii self-assigned this Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@no-reply no-reply

@jrgriffiniii jrgriffiniii

Labels
technical debt
Projects
None yet
Milestone
2.x series
Development

No branches or pull requests
5 participants
@cjcolvar @no-reply @jrgriffiniii @elrayle @laritakr