You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a work has single-valued attributes and the form is submitted, empty strings are stored.
Rationale
Having these values change after form submission means that views and other code that exports them has to check for nil and an empty string. It would cleaner for the values to remain nil unless they aren't an empty string.
Expected behavior
The value of the single-valued attribute is nil until it becomes a non-empty string.
Actual behavior
The value of blank single-valued attribute become "" after submitted the work form.
Descriptive summary
When a work has single-valued attributes and the form is submitted, empty strings are stored.
Rationale
Having these values change after form submission means that views and other code that exports them has to check for
nil
and an empty string. It would cleaner for the values to remain nil unless they aren't an empty string.Expected behavior
The value of the single-valued attribute is
nil
until it becomes a non-empty string.Actual behavior
The value of blank single-valued attribute become "" after submitted the work form.
Steps to reproduce the behavior
or view the show page:
Related work
curationexperts/epigaea#331
curationexperts/epigaea#618
The text was updated successfully, but these errors were encountered: