Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HydraEditor::Form.model_attributes incorrectly assumes all terms are multiple in cleaning #146

Closed
dchandekstark opened this issue Mar 20, 2018 · 1 comment
Closed

HydraEditor::Form.model_attributes incorrectly assumes all terms are multiple in cleaning #146

dchandekstark opened this issue Mar 20, 2018 · 1 comment
Assignees
@dchandekstark
Labels
bug

Comments

@dchandekstark
Copy link
Member

See samvera/hyrax#2296.

HydraEditor::Form.model_attributes cleans term values by removing empty strings, but this only works for multi-valued terms. Single-valued (multiple: false) terms should have empty string value '' replaced with nil.
dchandekstark added a commit to duke-libraries/rdr that referenced this issue Mar 20, 2018
@dchandekstark
Patches bug in hydra-editor.
92b170f 
Single-values fields (multiple: false) should have an empty
string value set to nil.

See samvera/hydra-editor#146.
@dchandekstark dchandekstark mentioned this issue Mar 20, 2018
Merged
@dchandekstark
Copy link
Member Author

dchandekstark commented Mar 20, 2018 •
edited
Loading

Patched in a Hyrax form class: https://github.com/duke-libraries/rdr/blob/92b170f918d8be90828aac53a57aeab1b1e0f7cb/app/forms/hyrax/dataset_form.rb#L40-L48

ad96 pushed a commit to duke-libraries/rdr that referenced this issue Mar 20, 2018
@dchandekstark @ad96
Patches bug in hydra-editor. (#77)
fa34fc3 
Single-values fields (multiple: false) should have an empty
string value set to nil.

See samvera/hydra-editor#146.
dchandekstark added a commit to dchandekstark/hydra-editor that referenced this issue Mar 20, 2018
@dchandekstark
Updates HydraEditor::Form.model_attributes.
f1cba1d 
For non-mulitple terms, an empty string value is replaced by nil.
Fixes samvera#146.
@dchandekstark dchandekstark mentioned this issue Mar 20, 2018
Merged
@aeschylus aeschylus removed the review label Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchandekstark dchandekstark

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dchandekstark @aeschylus