Restrict simple_form to <= 3.5.0
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beginning with `v3.5.1`, Simple Form now requires models passed to it to conform to the `ActiveModel` interface; particularly, they must implement `#to_model`. We will restrict to `<= 3.5.0` to prevent unexpected breakage for downstream apps. Support for `v3.5.1` and up should be readded (this may just require testing/documentation fixes) and a major version released to get us back to tracking current `simple_form` development. See also: samvera/hyrax#2758 and heartcombo/simple_form#1549.
jcoyne
approved these changes
Mar 5, 2018
no-reply
pushed a commit
to samvera/hyrax
that referenced
this pull request
May 4, 2018
The pin was initally introduced in #2663. `hydra-editor` now handles pinning of `simple_form` versions (see: samvera/hydra-editor#143) on its 3.x series. We support newer versions of `simple_form` via `hydra-editor` 4.x (see: samvera/hydra-editor#145). Fixes #2665.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning with
v3.5.1, Simple Form now requires models passed to it to conformto the
ActiveModelinterface; particularly, they must implement#to_model. We will restrict to<= 3.5.0to prevent unexpected breakage fordownstream apps.
Support for
v3.5.1and up should be readded (this may just requiretesting/documentation fixes) and a major version released to get us back to
tracking current
simple_formdevelopment.See also: samvera/hyrax#2758 and
heartcombo/simple_form#1549.