-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finite_state_machine: Add an example on the Gray code into the documentation #16143
Comments
Dependencies: #16141 |
Reviewer: Daniel Krenn |
Changed branch from u/cheuberg/fsm/example_gray_code to u/dkrenn/fsm/example_gray_code |
comment:4
During the review I realized that the Gray-code transducer (in generators) didn't have any final states. I've corrected this. I added a doctest to print the Gray code of the first 10 non-negative integers. Last 10 new commits:
|
Changed author from Clemens Heuberger to Clemens Heuberger, Daniel Krenn |
Changed branch from u/dkrenn/fsm/example_gray_code to u/cheuberg/fsm/example_gray_code |
comment:6
Modified example in Corrected link from |
Last 10 new commits:
|
Changed branch from u/cheuberg/fsm/example_gray_code to u/dkrenn/fsm/example_gray_code |
comment:8
Now bases on beta8 + #16142. Last 10 new commits:
|
Changed branch from u/dkrenn/fsm/example_gray_code to u/dkrenn/fsm/example_gray_code-on-beta8 |
comment:9
Cross-reviewed all changes by dkrenn, they are fine for me. Corrected left-shift transducer (it is a right-shift transducer, as highlighted by the above doctest) and explained this. |
Changed branch from u/dkrenn/fsm/example_gray_code-on-beta8 to u/cheuberg/fsm/example_gray_code |
Changed branch from u/cheuberg/fsm/example_gray_code to u/dkrenn/fsm/example_gray_code |
comment:12
Reviewed your changes...ok. Rewrote/Extended the documentation of the 'shift'-part of the example. Please review. New commits:
|
comment:13
Replying to @dkrenn:
fine for me. |
comment:14
I rewrote the documentation to clarify the position of the least significant digit and the direction of the shift. Please review. Everthing else is fine for me. |
Changed branch from u/dkrenn/fsm/example_gray_code to u/skropf/fsm/example_gray_code |
comment:15
fine for me. |
Changed author from Clemens Heuberger, Daniel Krenn to Clemens Heuberger, Daniel Krenn, Sara Kropf |
Changed reviewer from Daniel Krenn to Daniel Krenn, Sara Kropf |
comment:17
Fome also for me. Since all participants in this ticket agree, I give it a positive review. |
Changed branch from u/skropf/fsm/example_gray_code to |
As an example on how to use cartesian products of transducers as introduced in #16061, a transducer converting standard binary expansion into Gray code is constructed by emulating the standard algorithm by xoring the the standard binary expansion with its shifted version.
The class collecting common transducers introduced in #16141 now also has a (hard-coded) version of the same transducer and it is made sure that both transducers agree.
Depends on #16132
Depends on #16141
Depends on #16142
CC: @sagetrac-skropf
Component: combinatorics
Author: Clemens Heuberger, Daniel Krenn, Sara Kropf
Branch/Commit:
301b5cb
Reviewer: Daniel Krenn, Sara Kropf
Issue created by migration from https://trac.sagemath.org/ticket/16143
The text was updated successfully, but these errors were encountered: