Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transducers.add, transducers.sub, transducers.abs, transducer.operator: New common transducers #16142

Closed
cheuberg opened this issue Apr 12, 2014 · 22 comments
Closed

transducers.add, transducers.sub, transducers.abs, transducer.operator: New common transducers #16142

cheuberg opened this issue Apr 12, 2014 · 22 comments
Labels
c: combinatorics c: finite state machines p: minor / 4 t: enhancement
Milestone
sage-6.2

Comments

@cheuberg
Copy link
Contributor

In #16141, a class to collect common transducers was introduced. Here, we enhance this class by
a few more transducers which are mainly meant to be used as readily available components in cartesian products and/or compositions.

We introduce four more common transducers, transducers.abs realizing absolute value,
transducers.operator realizing binary operations, transducers.add, transducers.sub realizing addition and subtraction and at the same time illustrating the use of transducers.operator.

Depends on #16132
Depends on #16141

Component: combinatorics

Author: Clemens Heuberger, Daniel Krenn, Sara Kropf

Branch/Commit: a5087f2

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/16142
@cheuberg cheuberg added this to the sage-6.2 milestone Apr 12, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 12, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

fdd778cgenerators.operator: final state state

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 12, 2014

Changed commit from 3110f9d to fdd778c

@dkrenn
Copy link
Contributor

dkrenn commented Apr 15, 2014

Reviewer: Daniel Krenn

@dkrenn
Copy link
Contributor

dkrenn commented Apr 15, 2014

Changed author from Clemens Heuberger, Sara Kropf to Clemens Heuberger, Daniel Krenn, Sara Kropf

@dkrenn
Copy link
Contributor

dkrenn commented Apr 15, 2014

Changed branch from u/cheuberg/fsm/operator_transducers to u/dkrenn/fsm/operator_transducers

@dkrenn
Copy link
Contributor

dkrenn commented Apr 15, 2014

comment:3

During review, I decided to extend .operator to arbirary opeators (not only binary). I've rewritten its docstring. I've also made a couple of changes in the docstings of .add, .sub, .abs.

The patch looks good; doctests pass; docs checked. So this is a positive review for me, but please review my changes first.

Last 10 new commits:

547968aFiniteStateMachine.product_FiniteStateMachine, composition: fix unhashable colors
d51be51Automaton.determinisation(): docstring on hashable colors
c5dd860Merge branch 'fsm/state_color' into fsm/process_output_new
70294bftrac ticket number added
4a53b09Merge branch '#16132' into fsm/count_subblock_occurrences
5d65767Edit doctests due to #16132 change.
e1bd1dfMerge branch 'fsm/count_subblock_occurrences' into fsm/operator_transducers
3110f9dEdit doctests due to #16132 change.
fdd778cgenerators.operator: final state state
f344fd8reviewer patch: improved function operator; extended and rewrote docstrings

@dkrenn
Copy link
Contributor

dkrenn commented Apr 15, 2014

Changed commit from fdd778c to f344fd8

@dkrenn
Copy link
Contributor

dkrenn commented Apr 15, 2014

Dependencies: #16141

@dkrenn
Copy link
Contributor

dkrenn commented Apr 16, 2014

comment:5

The new branch is on beta8 + #16141. Positive from my side, but my changes (see above) have to be reviewed first.

Last 10 new commits:

70294bftrac ticket number added
ed93dd3Minor changes during review.
3820c49corrected whitespaceerror
a14dd81Merge remote-tracking branch 'origin/u/dkrenn/ticket/16132' into fsm/process_output_new-on-beta8
be59e47TransducerGenerators: New class, collecting common transducers
7a907acminor corrections
4a53b09Merge branch '#16132' into fsm/count_subblock_occurrences
5d65767Edit doctests due to #16132 change.
86f8452improved various docstrings in finite_state_machine_generators.py
4a36b1aMerge remote-tracking branch 'origin/u/dkrenn/fsm/count_subblock_occurrences' into fsm/count_subblock_occurrences-on-beta8

@dkrenn
Copy link
Contributor

dkrenn commented Apr 16, 2014

Changed branch from u/dkrenn/fsm/operator_transducers to u/dkrenn/fsm/operator_transducers-on-beta8

@dkrenn
Copy link
Contributor

dkrenn commented Apr 16, 2014

Changed commit from f344fd8 to 4a36b1a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 16, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

973d4d3transducers.add, transducers.sub: New transducers
86be453generators.abs: new common Transducer: absolute Value
fdf3dc4TransducerGenerators.operator is now a public function
92a2b26operator in TOC, corrected docstring
9029a07Fixed doctest for operator
e1bd1dfMerge branch 'fsm/count_subblock_occurrences' into fsm/operator_transducers
3110f9dEdit doctests due to #16132 change.
fdd778cgenerators.operator: final state state
f344fd8reviewer patch: improved function operator; extended and rewrote docstrings
138132fMerge remote-tracking branch 'origin/u/dkrenn/fsm/operator_transducers' into fsm/example_gray_code-on-beta8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 16, 2014

Changed commit from 4a36b1a to 138132f

@dkrenn
Copy link
Contributor

dkrenn commented Apr 16, 2014

Last 10 new commits:

973d4d3transducers.add, transducers.sub: New transducers
86be453generators.abs: new common Transducer: absolute Value
fdf3dc4TransducerGenerators.operator is now a public function
92a2b26operator in TOC, corrected docstring
9029a07Fixed doctest for operator
e1bd1dfMerge branch 'fsm/count_subblock_occurrences' into fsm/operator_transducers
3110f9dEdit doctests due to #16132 change.
fdd778cgenerators.operator: final state state
f344fd8reviewer patch: improved function operator; extended and rewrote docstrings
138132fMerge remote-tracking branch 'origin/u/dkrenn/fsm/operator_transducers' into fsm/example_gray_code-on-beta8

Last 10 new commits:

973d4d3transducers.add, transducers.sub: New transducers
86be453generators.abs: new common Transducer: absolute Value
fdf3dc4TransducerGenerators.operator is now a public function
92a2b26operator in TOC, corrected docstring
9029a07Fixed doctest for operator
e1bd1dfMerge branch 'fsm/count_subblock_occurrences' into fsm/operator_transducers
3110f9dEdit doctests due to #16132 change.
fdd778cgenerators.operator: final state state
f344fd8reviewer patch: improved function operator; extended and rewrote docstrings
138132fMerge remote-tracking branch 'origin/u/dkrenn/fsm/operator_transducers' into fsm/example_gray_code-on-beta8

@cheuberg
Copy link
Contributor Author

Changed dependencies from #16141 to #16132, #16141

@cheuberg
Copy link
Contributor Author

Changed branch from u/dkrenn/fsm/operator_transducers-on-beta8 to u/cheuberg/fsm/operator_transducers-on-beta8

@cheuberg
Copy link
Contributor Author

comment:10

cross reviewed your changes,fine with me, but added five small modifications in a few commits, please review again.

Last 10 new commits:

e1bd1dfMerge branch 'fsm/count_subblock_occurrences' into fsm/operator_transducers
3110f9dEdit doctests due to #16132 change.
fdd778cgenerators.operator: final state state
f344fd8reviewer patch: improved function operator; extended and rewrote docstrings
138132fMerge remote-tracking branch 'origin/u/dkrenn/fsm/operator_transducers' into fsm/example_gray_code-on-beta8
1fdedc5Remove superfluous line break in docstring
ef44f58replace lambda i: abs(i) by abs
2695293compare with buit-in abs
b1e7858link to builtin method .add
1ae96e6three modified docstrings

@cheuberg
Copy link
Contributor Author

Changed commit from 138132f to 1ae96e6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

a5087f2finite_state_machine_generators: acknowledge research grant

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2014

Changed commit from 1ae96e6 to a5087f2

@dkrenn
Copy link
Contributor

dkrenn commented Apr 22, 2014

comment:12

reviewed again, everything is fine :)

@vbraun
Copy link
Member

vbraun commented Apr 22, 2014

Changed branch from u/cheuberg/fsm/operator_transducers-on-beta8 to a5087f2

@vbraun vbraun closed this as completed in b8f91ab Apr 22, 2014
This was referenced May 7, 2014
Closed
Closed
Closed
@dkrenn dkrenn mentioned this issue Jul 19, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics c: finite state machines p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-6.2
Development

No branches or pull requests
3 participants
@vbraun @cheuberg @dkrenn