adapting output of FiniteStateMachine.process and __call__ to Automaton and Transducer

[dkrenn]

Currently, there is only .process and .__call__ in the abstract base class FiniteStateMachine. The outputs do not depend on the actual type (automaton/transducer). The aim of this ticket is to change this and produce an appropriate output for each type of finite state machine. When using .__call__ in an automaton this is whether an input was accepted (and not more); a transducer gives the only the produces output.

(Since there is a change in the output, we give a deprecation warning.)

Depends on #16128
Depends on #16061
Depends on #15990

CC: @cheuberg @sagetrac-skropf

Component: combinatorics

Keywords: finite state machine, process, output

Author: Daniel Krenn

Branch/Commit: afc15e5

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/16132

[dkrenn]

Author: Daniel Krenn

[dkrenn]

Commit: 70294bf

[dkrenn]

Last 10 new commits:

83b0341	corrected one whitespace error
7633cac	Transducer.cartesian_product: small correction in docstring
ab93aed	Merge branch 'fsm/cartesian-product-intersection' into fsm/process_output_new
75aa9e1	corrected doctests (after change of output)
d18312e	Merge branch 'fsm/state_color' into fsm/process_output_new
2d43fdd	FiniteStateMachine: add failing doctests: non-hashable colors
547968a	FiniteStateMachine.product_FiniteStateMachine, composition: fix unhashable colors
d51be51	Automaton.determinisation(): docstring on hashable colors
c5dd860	Merge branch 'fsm/state_color' into fsm/process_output_new
70294bf	trac ticket number added

[dkrenn]

Branch: u/dkrenn/fsm/process_output_new

[dkrenn]

Dependencies: #15963, #16061

[cheuberg]

Changed branch from u/dkrenn/fsm/process_output_new to u/cheuberg/ticket/16132

[cheuberg]

Changed dependencies from #15963, #16061 to #16128, #16061

[cheuberg]

Changed commit from 70294bf to ed93dd3

[cheuberg]

comment:6

Reviewed this patch, made minor modifications.

Replaced dependency on #15963 by #16128: #16128 is a revision of #15963 (see explanation in #16128 for background) and this patch is actually based on #16128.

[cheuberg]

Reviewer: Clemens Heuberger

[dkrenn]

Changed branch from u/cheuberg/ticket/16132 to u/dkrenn/ticket/16132

[dkrenn]

comment:7

Cross-reviewed your changes; corrected one whitespaceerror. Feel free to set its status to positive_review.

---

Last 10 new commits:

ab93aed	Merge branch 'fsm/cartesian-product-intersection' into fsm/process_output_new
75aa9e1	corrected doctests (after change of output)
d18312e	Merge branch 'fsm/state_color' into fsm/process_output_new
2d43fdd	FiniteStateMachine: add failing doctests: non-hashable colors
547968a	FiniteStateMachine.product_FiniteStateMachine, composition: fix unhashable colors
d51be51	Automaton.determinisation(): docstring on hashable colors
c5dd860	Merge branch 'fsm/state_color' into fsm/process_output_new
70294bf	trac ticket number added
ed93dd3	Minor changes during review.
3820c49	corrected whitespaceerror

[dkrenn]

Changed commit from ed93dd3 to 3820c49

[dkrenn]

comment:9

Does not merge on beta8.

[dkrenn]

Changed dependencies from #16128, #16061 to #16128, #16061, #15990

[dkrenn]

comment:11

Is now working on beta8. Please review changes.

---

Last 10 new commits:

75aa9e1	corrected doctests (after change of output)
d18312e	Merge branch 'fsm/state_color' into fsm/process_output_new
2d43fdd	FiniteStateMachine: add failing doctests: non-hashable colors
547968a	FiniteStateMachine.product_FiniteStateMachine, composition: fix unhashable colors
d51be51	Automaton.determinisation(): docstring on hashable colors
c5dd860	Merge branch 'fsm/state_color' into fsm/process_output_new
70294bf	trac ticket number added
ed93dd3	Minor changes during review.
3820c49	corrected whitespaceerror
a14dd81	Merge remote-tracking branch 'origin/u/dkrenn/ticket/16132' into fsm/process_output_new-on-beta8

[dkrenn]

Changed branch from u/dkrenn/ticket/16132 to u/dkrenn/fsm_process_output_new-on-beta8

[dkrenn]

Changed commit from 3820c49 to a14dd81

[cheuberg]

Changed branch from u/dkrenn/fsm_process_output_new-on-beta8 to u/cheuberg/fsm_process_output_new-on-beta8

[cheuberg]

comment:13

Reviewed the above merge with develop, merge is fine, doctests pass.

Replaced two raise E, V by raise E(V) in the spirit of #15990 which had been merged previously.

[cheuberg]

Changed commit from a14dd81 to afc15e5

[dkrenn]

comment:14

Replying to @cheuberg:

Replaced two raise E, V by raise E(V) in the spirit of #15990 which had been merged previously.

Cross-reviewed: ok.

[vbraun]

Changed branch from u/cheuberg/fsm_process_output_new-on-beta8 to afc15e5