Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransducerGenerators: New class, collecting common transducers #16141

Closed
cheuberg opened this issue Apr 12, 2014 · 10 comments
Closed

TransducerGenerators: New class, collecting common transducers #16141

cheuberg opened this issue Apr 12, 2014 · 10 comments

Comments

@cheuberg
Copy link
Contributor

Inspired by the (Di)graph_generators, provide a class
TransducerGenerators where commonly usable transducers
performing simple tasks can be collected. As for graphs,
an abbreviation transducers is injected in the global
namespace by a lazy_import.

To start with, there is a Identity transducer and
a CountSubblockOccurrences transducer.

Depends on #15849
Depends on #16132

CC: @sagetrac-skropf

Component: combinatorics

Author: Clemens Heuberger, Daniel Krenn, Sara Kropf

Branch/Commit: 4a36b1a

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/16141

@cheuberg cheuberg added this to the sage-6.2 milestone Apr 12, 2014
@dkrenn
Copy link
Contributor

dkrenn commented Apr 15, 2014

Changed commit from 5d65767 to 86f8452

@dkrenn
Copy link
Contributor

dkrenn commented Apr 15, 2014

Reviewer: Daniel Krenn

@dkrenn
Copy link
Contributor

dkrenn commented Apr 15, 2014

@dkrenn
Copy link
Contributor

dkrenn commented Apr 15, 2014

comment:2

During the review, I rewrote parts of the docstring of the new generator file (inserted some text at the top; some minor changes). Please review those changes.

For me this is a positive review (all tests pass, docs looking fine, coverage 100%), so if someones agrees with my changes, change the status of this ticket.


Last 10 new commits:

75aa9e1corrected doctests (after change of output)
d18312eMerge branch 'fsm/state_color' into fsm/process_output_new
2d43fddFiniteStateMachine: add failing doctests: non-hashable colors
547968aFiniteStateMachine.product_FiniteStateMachine, composition: fix unhashable colors
d51be51Automaton.determinisation(): docstring on hashable colors
c5dd860Merge branch 'fsm/state_color' into fsm/process_output_new
70294bftrac ticket number added
4a53b09Merge branch '#16132' into fsm/count_subblock_occurrences
5d65767Edit doctests due to #16132 change.
86f8452improved various docstrings in finite_state_machine_generators.py

@dkrenn
Copy link
Contributor

dkrenn commented Apr 15, 2014

Changed author from Clemens Heuberger, Sara Kropf to Clemens Heuberger, Daniel Krenn, Sara Kropf

@cheuberg
Copy link
Contributor Author

comment:4

Replying to @dkrenn:

During the review, I rewrote parts of the docstring of the new generator file (inserted some text at the top; some minor changes). Please review those changes.

For me this is a positive review (all tests pass, docs looking fine, coverage 100%), so if someones agrees with my changes, change the status of this ticket.

I reviewed your changes and agree with them.

@dkrenn
Copy link
Contributor

dkrenn commented Apr 16, 2014

comment:6

This merges on 6.2.beta8 + #16132


Last 10 new commits:

70294bftrac ticket number added
ed93dd3Minor changes during review.
3820c49corrected whitespaceerror
a14dd81Merge remote-tracking branch 'origin/u/dkrenn/ticket/16132' into fsm/process_output_new-on-beta8
be59e47TransducerGenerators: New class, collecting common transducers
7a907acminor corrections
4a53b09Merge branch '#16132' into fsm/count_subblock_occurrences
5d65767Edit doctests due to #16132 change.
86f8452improved various docstrings in finite_state_machine_generators.py
4a36b1aMerge remote-tracking branch 'origin/u/dkrenn/fsm/count_subblock_occurrences' into fsm/count_subblock_occurrences-on-beta8

@dkrenn
Copy link
Contributor

dkrenn commented Apr 16, 2014

Changed commit from 86f8452 to 4a36b1a

@dkrenn
Copy link
Contributor

dkrenn commented Apr 16, 2014

@vbraun
Copy link
Member

vbraun commented Apr 20, 2014

Changed branch from u/dkrenn/fsm/count_subblock_occurrences-on-beta8 to 4a36b1a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants