-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransducerGenerators: New class, collecting common transducers #16141
Comments
Reviewer: Daniel Krenn |
Changed branch from u/cheuberg/fsm/count_subblock_occurrences to u/dkrenn/fsm/count_subblock_occurrences |
comment:2
During the review, I rewrote parts of the docstring of the new generator file (inserted some text at the top; some minor changes). Please review those changes. For me this is a positive review (all tests pass, docs looking fine, coverage 100%), so if someones agrees with my changes, change the status of this ticket. Last 10 new commits:
|
Changed author from Clemens Heuberger, Sara Kropf to Clemens Heuberger, Daniel Krenn, Sara Kropf |
comment:4
Replying to @dkrenn:
I reviewed your changes and agree with them. |
comment:6
This merges on 6.2.beta8 + #16132 Last 10 new commits:
|
Changed branch from u/dkrenn/fsm/count_subblock_occurrences to u/dkrenn/fsm/count_subblock_occurrences-on-beta8 |
Changed branch from u/dkrenn/fsm/count_subblock_occurrences-on-beta8 to |
Inspired by the (Di)graph_generators, provide a class
TransducerGenerators
where commonly usable transducersperforming simple tasks can be collected. As for graphs,
an abbreviation transducers is injected in the global
namespace by a lazy_import.
To start with, there is a Identity transducer and
a
CountSubblockOccurrences
transducer.Depends on #15849
Depends on #16132
CC: @sagetrac-skropf
Component: combinatorics
Author: Clemens Heuberger, Daniel Krenn, Sara Kropf
Branch/Commit:
4a36b1a
Reviewer: Daniel Krenn
Issue created by migration from https://trac.sagemath.org/ticket/16141
The text was updated successfully, but these errors were encountered: