Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Audit Report #139

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Add Audit Report #139

merged 4 commits into from
Nov 10, 2023

Conversation

nlordell
Copy link
Collaborator

@nlordell nlordell commented Nov 9, 2023

This PR adds the audit report from Ackee. Sweet and simple.

@nlordell nlordell requested a review from a team as a code owner November 9, 2023 16:24
@nlordell nlordell requested review from rmeissner, akshay-ap and mmv08 and removed request for a team November 9, 2023 16:24
@mmv08
Copy link
Member

mmv08 commented Nov 9, 2023 •
edited
Loading

Shall we link it in the modules readme similarly to how we do it in the safe-contracts repo?

https://github.com/safe-global/safe-contracts#audits-formal-verification

@coveralls
Copy link

coveralls commented Nov 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6821800801

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6795647769: 0.0%
Covered Lines: 27
Relevant Lines: 27
💛 - Coveralls

@nlordell
Copy link
Collaborator Author

@mmv08 - added some additional markdown documentation associated with the audit inspired by the safe-contracts repository.

@nlordell nlordell mentioned this pull request Nov 10, 2023
Closed
@nlordell nlordell merged commit 2790287 into master Nov 10, 2023
3 checks passed
@nlordell nlordell deleted the add-audit-report branch November 10, 2023 10:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmv08 mmv08 mmv08 approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap was automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlordell @mmv08 @coveralls