Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Audit Report #139

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Add Audit Report #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8dd3508
Add Audit Report
nlordell Nov 9, 2023
9676d43
Added additional audit documentation
nlordell Nov 10, 2023
26e3a6e
english
nlordell Nov 10, 2023
f31b22c
prettier lint
nlordell Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions 4337/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ npx hardhat --network <network> etherscan-verify

- [Safe developer portal](http://docs.safe.global)

## Audits

- [For version 0.1.0 by Ackee Blockchain](docs/v0.1.0/audit.md)

## Security and Liability

All contracts are WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Expand Down
Binary file added 4337/docs/v0.1.0/audit-report-v1.1.pdf
View file
Open in desktop
Binary file not shown.
23 changes: 23 additions & 0 deletions 4337/docs/v0.1.0/audit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Audit Results

## Auditor

Ackee Blockchain (<https://ackeeblockchain.com/>).

## Notes

The final audit was performed on commit [1981fbc63e3850d626074d81d22a198afe64ac03](https://github.com/safe-global/safe-modules/tree/1981fbc63e3850d626074d81d22a198afe64ac03).

There are two acknowledged findings from the audit report:

- _W2: Usage of `solc` optimizer_
> After careful consideration, we decided to enable the optimizer for the following reasons:
>
> - The most critical functionality, such as signature checks and replay protection, is handled by the Safe and Entrypoint contracts.
> - The entrypoint contract uses the optimizer.
- _I4: Contract does not allow to specify `validAfter` and `validUntil` parameters_
> We are choosing not to support this feature at the moment but may implement it in a follow-up revision of the module.

## Files

- [Final audit report](audit-report-v1.1.pdf)