-
Notifications
You must be signed in to change notification settings - Fork 81
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This PR adds the audit report from Ackee. Sweet and simple.
- Loading branch information
Showing
3 changed files
with
27 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Audit Results | ||
|
||
## Auditor | ||
|
||
Ackee Blockchain (<https://ackeeblockchain.com/>). | ||
|
||
## Notes | ||
|
||
The final audit was performed on commit [1981fbc63e3850d626074d81d22a198afe64ac03](https://github.com/safe-global/safe-modules/tree/1981fbc63e3850d626074d81d22a198afe64ac03). | ||
|
||
There are two acknowledged findings from the audit report: | ||
|
||
- _W2: Usage of `solc` optimizer_ | ||
> After careful consideration, we decided to enable the optimizer for the following reasons: | ||
> | ||
> - The most critical functionality, such as signature checks and replay protection, is handled by the Safe and Entrypoint contracts. | ||
> - The entrypoint contract uses the optimizer. | ||
- _I4: Contract does not allow to specify `validAfter` and `validUntil` parameters_ | ||
> We are choosing not to support this feature at the moment but may implement it in a follow-up revision of the module. | ||
## Files | ||
|
||
- [Final audit report](audit-report-v1.1.pdf) |