Skip to content

Commit

Permalink
Add Audit Report (#139)
Browse files Browse the repository at this point in the history
This PR adds the audit report from Ackee. Sweet and simple.
  • Loading branch information
nlordell authored Nov 10, 2023
1 parent c0a5cbe commit 2790287
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 0 deletions.
4 changes: 4 additions & 0 deletions 4337/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ npx hardhat --network <network> etherscan-verify

- [Safe developer portal](http://docs.safe.global)

## Audits

- [For version 0.1.0 by Ackee Blockchain](docs/v0.1.0/audit.md)

## Security and Liability

All contracts are WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Expand Down
Binary file added 4337/docs/v0.1.0/audit-report-v1.1.pdf
Binary file not shown.
23 changes: 23 additions & 0 deletions 4337/docs/v0.1.0/audit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Audit Results

## Auditor

Ackee Blockchain (<https://ackeeblockchain.com/>).

## Notes

The final audit was performed on commit [1981fbc63e3850d626074d81d22a198afe64ac03](https://github.com/safe-global/safe-modules/tree/1981fbc63e3850d626074d81d22a198afe64ac03).

There are two acknowledged findings from the audit report:

- _W2: Usage of `solc` optimizer_
> After careful consideration, we decided to enable the optimizer for the following reasons:
>
> - The most critical functionality, such as signature checks and replay protection, is handled by the Safe and Entrypoint contracts.
> - The entrypoint contract uses the optimizer.
- _I4: Contract does not allow to specify `validAfter` and `validUntil` parameters_
> We are choosing not to support this feature at the moment but may implement it in a follow-up revision of the module.
## Files

- [Final audit report](audit-report-v1.1.pdf)

0 comments on commit 2790287

Please sign in to comment.