Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(errors): use correct error variant for data encryption #323

Merged
merged 3 commits into from
Oct 9, 2024
Merged

fix(errors): use correct error variant for data encryption #323

merged 3 commits into from
Oct 9, 2024

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Oct 8, 2024 •
edited
Loading

Based on #322

@simonsan
fix(errors): use correct error variant for data encryption
e27aff3 
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan simonsan added A-errors Area: error handling needs improvement C-bug Category: Something isn't working as expected labels Oct 8, 2024
@simonsan
refactor(errors): improve displaying of errors
470814b 
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan simonsan requested a review from aawsome October 8, 2024 05:20
@simonsan simonsan added the S-waiting-for-review Status: PRs waiting for review label Oct 8, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.8%. Comparing base (b5fda12) to head (470814b).

Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/crypto/aespoly1305.rs 85.0% <ø> (ø)
crates/core/src/error.rs 71.4% <ø> (+14.2%) ⬆️

... and 18 files with indirect coverage changes

@simonsan simonsan added this to the NEXT milestone Oct 8, 2024
@aawsome aawsome added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 460865b Oct 9, 2024
22 checks passed
@aawsome aawsome deleted the fix/error-data-enc branch October 9, 2024 07:13
@rustic-release-plz rustic-release-plz bot mentioned this pull request Oct 8, 2024
Merged
@simonsan simonsan mentioned this pull request Oct 9, 2024
Closed
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2024
@rustic-release-plz
chore(rustic_core): release v0.5.2 (#312)
0f61e3c 
## 🤖 New release
* `rustic_core`: 0.5.1 -> 0.5.2 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_core`
<blockquote>

##
[0.5.2](rustic_core-v0.5.1...rustic_core-v0.5.2)
- 2024-10-09

### Fixed

- *(errors)* use correct error variant for data encryption
([#323](#323))
- *(errors)* handle out of bounds access in PathList display
([#313](#313))
- *(errors)* better error message for hot/cold repo in check
([#297](#297))

### Other

- *(commands)* decouple logic from option structs for check, prune,
repair, key, and restore
([#317](#317))
- *(errors)* improve message and add logging when sending tree from
backend panics
([#314](#314))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aawsome aawsome aawsome approved these changes

Assignees
No one assigned
Labels
A-errors Area: error handling needs improvement C-bug Category: Something isn't working as expected S-waiting-for-review Status: PRs waiting for review
Projects
None yet
Milestone
NEXT
Development

Successfully merging this pull request may close these issues.
2 participants
@simonsan @aawsome