Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(errors): handle out of bounds access in PathList display #313

Merged
merged 3 commits into from
Oct 6, 2024
Merged

fix(errors): handle out of bounds access in PathList display #313

merged 3 commits into from
Oct 6, 2024

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Oct 5, 2024

Fixes #309

@simonsan
fix: handle out of bounds access in PathList display
e9176b2 
Fixes #309

Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan simonsan added the C-bug Category: Something isn't working as expected label Oct 5, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.5%. Comparing base (f68ffa3) to head (dcc2e73).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/repofile/snapshotfile.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/repofile/snapshotfile.rs 50.2% <0.0%> (ø)

... and 18 files with indirect coverage changes

@simonsan
use different implementation and impl tests
13efb2e 
Signed-off-by: simonsan <14062932+simonsan@users.noreply.github.com>
@simonsan simonsan requested a review from aawsome October 5, 2024 18:34
@simonsan simonsan added the S-waiting-for-review Status: PRs waiting for review label Oct 5, 2024
@simonsan simonsan changed the title fix: handle out of bounds access in PathList display fix(errors): handle out of bounds access in PathList display Oct 5, 2024
aawsome
aawsome approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@aawsome aawsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/core/src/repofile/snapshotfile.rs Outdated Show resolved Hide resolved
@simonsan simonsan enabled auto-merge October 6, 2024 20:03
@simonsan simonsan removed the S-waiting-for-review Status: PRs waiting for review label Oct 6, 2024
@simonsan simonsan added this pull request to the merge queue Oct 6, 2024
Merged via the queue into main with commit be4f18f Oct 6, 2024
24 of 25 checks passed
@simonsan simonsan deleted the fix/309 branch October 6, 2024 20:22
@rustic-release-plz rustic-release-plz bot mentioned this pull request Oct 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2024
@rustic-release-plz
chore(rustic_core): release v0.5.2 (#312)
0f61e3c 
## 🤖 New release
* `rustic_core`: 0.5.1 -> 0.5.2 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_core`
<blockquote>

##
[0.5.2](rustic_core-v0.5.1...rustic_core-v0.5.2)
- 2024-10-09

### Fixed

- *(errors)* use correct error variant for data encryption
([#323](#323))
- *(errors)* handle out of bounds access in PathList display
([#313](#313))
- *(errors)* better error message for hot/cold repo in check
([#297](#297))

### Other

- *(commands)* decouple logic from option structs for check, prune,
repair, key, and restore
([#317](#317))
- *(errors)* improve message and add logging when sending tree from
backend panics
([#314](#314))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aawsome aawsome aawsome approved these changes

Assignees
No one assigned
Labels
C-bug Category: Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

range start index 1 out of range for slice of length 0
2 participants
@simonsan @aawsome