Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(errors): better error message for hot/cold repo in check #297

Merged
merged 4 commits into from
Oct 5, 2024
Merged

fix(errors): better error message for hot/cold repo in check #297

merged 4 commits into from
Oct 5, 2024

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Oct 2, 2024

@simonsan simonsan added A-errors Area: error handling needs improvement C-bug Category: Something isn't working as expected S-waiting-for-review Status: PRs waiting for review labels Oct 2, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 45.9%. Comparing base (e84373e) to head (cbb61a3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/commands/check.rs 0.0% 13 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/commands/check.rs 63.5% <0.0%> (-3.6%) ⬇️

... and 9 files with indirect coverage changes

@simonsan simonsan removed the S-waiting-for-review Status: PRs waiting for review label Oct 3, 2024
@simonsan simonsan marked this pull request as draft October 3, 2024 12:18
@aawsome aawsome force-pushed the fix/check-error-msg branch from a98cbbc to 9de117f Compare October 4, 2024 21:37
@aawsome aawsome changed the title fix(errors): state more precisely in check error message, which packs are not referenced in index fix(errors): better error message for hot/cold repo in check Oct 4, 2024
@aawsome aawsome marked this pull request as ready for review October 4, 2024 21:39
@simonsan simonsan merged commit f68ffa3 into main Oct 5, 2024
24 of 25 checks passed
@simonsan simonsan deleted the fix/check-error-msg branch October 5, 2024 12:56
@rustic-release-plz rustic-release-plz bot mentioned this pull request Oct 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2024
@rustic-release-plz
chore(rustic_core): release v0.5.2 (#312)
0f61e3c 
## 🤖 New release
* `rustic_core`: 0.5.1 -> 0.5.2 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_core`
<blockquote>

##
[0.5.2](rustic_core-v0.5.1...rustic_core-v0.5.2)
- 2024-10-09

### Fixed

- *(errors)* use correct error variant for data encryption
([#323](#323))
- *(errors)* handle out of bounds access in PathList display
([#313](#313))
- *(errors)* better error message for hot/cold repo in check
([#297](#297))

### Other

- *(commands)* decouple logic from option structs for check, prune,
repair, key, and restore
([#317](#317))
- *(errors)* improve message and add logging when sending tree from
backend panics
([#314](#314))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aawsome aawsome aawsome left review comments

Assignees
No one assigned
Labels
A-errors Area: error handling needs improvement C-bug Category: Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check: Error message is unclear when hot repo is referencing unindexed packs of different type
2 participants
@simonsan @aawsome