Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moveit_pyサンプルパッケージ追加 #203

Merged
merged 48 commits into from
Feb 3, 2025
Merged

moveit_pyサンプルパッケージ追加 #203

merged 48 commits into from
Feb 3, 2025

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Jan 21, 2025

What does this implement/fix?

moveit_pyを使用したサンプルパッケージを追加します。

Sciurus17とできるだけ同じ実装になるようにしています。
製品間で異なる実装になっていないことも軽くご確認お願いします。
rt-net/sciurus17_ros#164

Does this close any currently open issues?

しません

How has this been tested?

パッケージ内のREADME記載の手順で各サンプルが動作することを確認します。
example.launch.pyを使用したサンプルは実機、mock components、Gazebo環境で動作することを確認します。
camera_example.launch.pyを使用したサンプルは実機のみで動作確認します。

Any other comments?

ないです。

Checklists

@Kuwamai Kuwamai added the Type: Feature New Feature label Jan 21, 2025
@Kuwamai Kuwamai self-assigned this Jan 21, 2025
@Kuwamai Kuwamai requested a review from YusukeKato January 29, 2025 07:13
@Kuwamai Kuwamai marked this pull request as ready for review January 29, 2025 07:14
@YusukeKato
Copy link
Contributor

Gazebo環境でcrane_x7_examples_py example.launch.pyのサンプルの動作確認できました。

@YusukeKato
Copy link
Contributor

Mock Componentsを用いてcrane_x7_examples_py example.launch.pyのサンプルの動作確認できました。

Copy link
Contributor

@YusukeKato YusukeKato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コードレビューを行いました。コメントの確認をお願いいたします。

また、crane_x7_ros/README.mdcrane_x7_ros/README.en.mdPackagesの項目にcrane_x7_examples_pyパッケージの説明を追加する必要がありそうです。

crane_x7_examples_py/LICENSE Outdated Show resolved Hide resolved
crane_x7_examples_py/README.md Outdated Show resolved Hide resolved
crane_x7_examples_py/README.md Outdated Show resolved Hide resolved
crane_x7_examples_py/package.xml Show resolved Hide resolved
crane_x7_examples_py/setup.py Show resolved Hide resolved
crane_x7_examples_py/setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@YusukeKato YusukeKato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます。
LGTMです!

@YusukeKato YusukeKato merged commit 7f9ac8c into ros2 Feb 3, 2025
1 check passed
@YusukeKato YusukeKato deleted the moveit_py branch February 3, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants