core: comment unnecessary namespace for now #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is not the most elegant solution, I would like to do something similar to rook, but for that, I'll need to change the whole |
travisn
requested changes
Jun 15, 2023
| @@ -38,8 +39,10 @@ var RootCmd = &cobra.Command{ | |||
| Args: cobra.MinimumNArgs(1), | |||
| TraverseChildren: true, | |||
| PersistentPreRun: func(cmd *cobra.Command, args []string) { | |||
| logging.Info("CephCluster namespace: %q", CephClusterNamespace) | |||
There was a problem hiding this comment.
Before we create a new debug option, how about if we just comment out these two lines for now? Perhaps we don't even need a debug mode, or may use a different approach.
6bfa2e9 to
c774588
Compare
Signed-off-by: subhamkrai <srai@redhat.com>
c774588 to
d2cb829
Compare
travisn
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core: comment unnecessary namespace for now
fixes: #118