Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: comment unnecessary namespace for now #124

Merged
merged 1 commit into from
Jun 15, 2023
Merged

core: comment unnecessary namespace for now #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/commands/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ var RootCmd = &cobra.Command{
Args: cobra.MinimumNArgs(1),
TraverseChildren: true,
PersistentPreRun: func(cmd *cobra.Command, args []string) {
logging.Info("CephCluster namespace: %q", CephClusterNamespace)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we create a new debug option, how about if we just comment out these two lines for now? Perhaps we don't even need a debug mode, or may use a different approach.

logging.Info("Rook operator namespace: %q", OperatorNamespace)
// logging.Info("CephCluster namespace: %q", CephClusterNamespace)
// logging.Info("Rook operator namespace: %q", OperatorNamespace)
},
}

Expand Down
1 change: 1 addition & 0 deletions pkg/logging/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,4 @@ func Fatal(err error, args ...interface{}) {
fmt.Println()
os.Exit(1)
}