Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace information is printed every time unexpectedly #118

Closed
travisn opened this issue Jun 13, 2023 · 1 comment · Fixed by #121 or #124
Closed

Namespace information is printed every time unexpectedly #118

travisn opened this issue Jun 13, 2023 · 1 comment · Fixed by #121 or #124
Labels
block-golang-release

Comments

@travisn
Copy link
Member

travisn commented Jun 13, 2023

Every command seems to print the namespace and version info. This makes it difficult to find the output that I care about. For example, here is the output for the operator set command:

% bin/kubectl-rook-ceph operator set foo bar
Info: CephCluster namespace: "rook-ceph"
Info: Rook operator namespace: "rook-ceph"
rook: v1.11.0-alpha.0.410.g97bf52d76
go: go1.19.7

Warning: rook version 'rook: v1.11.0-alpha.0.410.g97bf52d76
go: go1.19.7
' is running a pre-release version of Rook.
Info: configmap/rook-ceph-operator-config patched

I would expect output to only include the warning and then the related output:

% bin/kubectl-rook-ceph operator set foo bar
Warning: rook version 'rook: v1.11.0-alpha.0.410.g97bf52d76' is running a pre-release version of Rook.

Info: configmap/rook-ceph-operator-config patched
subhamkrai added a commit to subhamkrai/kubectl-rook-ceph that referenced this issue Jun 14, 2023
@subhamkrai
core: print version info only once
b9a1cea 
there was extra `fmt.Print()` in method `RunCommandInOperatorPod`
due to which command output was printed two times.

fixes: rook#118
Signed-off-by: subhamkrai <srai@redhat.com>
subhamkrai added a commit to subhamkrai/kubectl-rook-ceph that referenced this issue Jun 14, 2023
@subhamkrai
core: print version info only once
c558309 
there was extra `fmt.Print()` in method `RunCommandInOperatorPod`
due to which command output was printed two times.

fixes: rook#118
Signed-off-by: subhamkrai <srai@redhat.com>
@subhamkrai subhamkrai mentioned this issue Jun 14, 2023
Merged
@travisn
Copy link
Member Author

travisn commented Jun 14, 2023

The version is fixed, but the namespace is still unexpected to print every time. How about making these debug level?

Info: CephCluster namespace: "rook-ceph"
Info: Rook operator namespace: "rook-ceph"

@travisn travisn reopened this Jun 14, 2023
@travisn travisn changed the title Version information is printed every time unexpectedly Namespace information is printed every time unexpectedly Jun 14, 2023
@subhamkrai subhamkrai mentioned this issue Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
block-golang-release
Projects
None yet
Milestone
No milestone
1 participant
@travisn