Update Poetry build system & normalise on Python 3.11 #2703 #2754 #2693 #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uninstall prior Poetry 1.1.15, if found, using official installer script, and install 1.7.1 using Python 3.11 and OS pipx package: `build.sh`. ## Includes: - New Poetry install location: `/root/.local/bin` to `/usr/local/bin` - Update rockstor.service & rockstor-pre.service Poetry path. - Python 3.9 to Python 3.11 in pyproject.toml. - Refreshed poetry.lock created using Poetry 1.7.1. - Incidental update of setuptools (68.2.2 -> 69.0.2). - Incidental clarification re developer instructions in build.sh. - .gitignore addition re poetry-installer-error logs.
TestingSee linked rockstor-rpmbuild partner PR (rockstor/rockstor-rpmbuild#52) for the majority of the testing info: given these changes are to be assessed in sync with those in our rpmbuild spec file changes. RPMs were build, and installed successfully on the build hosts, for all target OS variations (Leap 15.4/15.5 & TW) & architectures (amd64 & aarch64). |
|
@FroggyFlox & @Hooverdan96 Merging as-is as we clear up three outstanding issues, with a hefty technical dept assistance; and we have clear-cut positive test results re the indicated issues. Plus these multi repo partnered issues are a little cumbersome to have hanging open. |
This was referenced Nov 24, 2023
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uninstall prior Poetry 1.1.15, if found, using official installer script, and install 1.7.1 using Python 3.11 and OS pipx package:
build.sh.Thanks to @FroggyFlox for assisting with development.
Includes:
/root/.local/binto/usr/local/binFixes #2703
Fixes #2754
Fixes #2693 see testing comment below(#2755 (comment))
See also partner:
Issue re rpmbuild: rockstor/rockstor-rpmbuild#50
PR re rpmbuild: rockstor/rockstor-rpmbuild#52