Failure to remove legacy poetry version in 5.0.6-0 rpm

[phillxnet]

Thanks to @FroggyFlox for highlighting this issue. During rpm update, we execute our build.sh script from within rpmbuild's %posttrans scriptlet. As from rpm 5.0.6-0 the build.sh shell script also:

• removes our legacy Poetry 1.1.15, installed (in /root/.local/bin/) via upstream installer script,
• and installs (in /usr/local/bin/) a far newer Poetry 1.7.1 under Py3.11 via OS supplied python3.11 pipx ,

This new Poetry update mechanism was part of the following pull request:
Update Poetry build system & normalise on Python 3.11 #2703 #2754 #2693 by @phillxnet @FroggyFlox in #2755

However; during more recent update testing concerning our next Stable release (from our last), given we are now in Release Candidate phase in testin updates/branch, a 4.6.1-0 machine failed to update to a pre-release rpm version of 5.0.6-2781.

The /var/log/zypp/history rpm log had the following contents.

# 2024-01-22 13:53:58 %posttrans(rockstor-5.0.6-2781.x86_64) script output:
# Current DB format is already 13.
# which: no poetry in (/usr/local/bin:/opt/rockstor/.venv/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)
# creating virtual environment...
# creating shared libraries...
# upgrading shared libraries...
# installing poetry from spec 'poetry==1.7.1'...
# done! ✨ 🌟 ✨#   installed package poetry 1.7.1, installed using Python 3.11.5
#   These apps are now globally available
#     - poetry
# No config-backups-rpmsave directory found.
``
Noteworthy here is no the **no poetry in ...** line. When the prior install was a Poetry variant: 4.6.1-0 with the following poetry-install-txt:

```bash
installer:~ # cat /opt/rockstor/poetry-install.txt 
The currently activated Python version 3.6.15 is not supported by the project (~2.7).
Trying to find and use a compatible version. 
Using python2 (2.7.18)
Creating virtualenv rockstor in /opt/rockstor/.venv
Installing dependencies from lock file

Package operations: 29 installs, 0 updates, 0 removals

  • Installing certifi (2021.10.8)
  • Installing chardet (4.0.0)
  • Installing greenlet (2.0.2)
  • Installing idna (2.10)
  • Installing pytz (2022.6)
  • Installing six (1.16.0)
  • Installing urllib3 (1.26.12)
  • Installing django (1.11.29)
  • Installing gevent (1.1.2)
  • Installing oauthlib (3.1.0)
  • Installing python-engineio (2.3.2)
  • Installing requests (2.27.1)
  • Installing dbus-python (1.2.18)
  • Installing distro (1.6.0)
  • Installing django-oauth-toolkit (1.1.2)
  • Installing djangorestframework (3.9.3)
  • Installing django-pipeline (1.6.9)
  • Installing django-braces (1.13.0)
  • Installing gevent-websocket (0.9.5)
  • Installing gunicorn (19.10.0)
  • Installing huey (2.3.0)
  • Installing mock (1.0.1)
  • Installing psutil (5.9.4)
  • Installing psycogreen (1.0)
  • Installing psycopg2 (2.8.6)
  • Installing python-socketio (1.6.0)
  • Installing pyzmq (19.0.2)
  • Installing supervisor (4.2.4)
  • Installing urlobject (2.1.1)

Installing the current project: rockstor (4.6.1)

Where-as post this Leap 15.4 reproducer system (zypper dup'ed from 15.3) we have the following contents:

installer:~ # cat /opt/rockstor/poetry-install.txt 

Command ['python', '-I', '-W', 'ignore', '-c', 'import sys\n\nif hasattr(sys, "real_prefix"):\n    print(sys.real_prefix)\nelif hasattr(sys, "base_prefix"):\n    print(sys.base_prefix)\nelse:\n    print(sys.prefix)\n'] errored with the following return code 2

Error output:
Unknown option: -I
usage: python [option] ... [-c cmd | -m mod | file | -] [arg] ...
Try `python -h' for more information.

So we see the failure of the legacy Poerty to:

1. be found by the rpm invoked %posttrans env.
2. consequently of 1. not actually be removed.

linstaller:~ # which poetry
/root/.local/bin/poetry

and we also have the newer version inappropriately co-resident, as per pipx's feedback within the above log excerpt, and from:

installer:~ # ls -la /usr/local/bin/
total 4
drwxr-xr-x 1 root root 12 Jan 22 13:54 .
drwxr-xr-x 1 root root 66 Mar 15  2022 ..
lrwxrwxrwx 1 root root 33 Jan 22 13:54 poetry -> /opt/pipx/venvs/poetry/bin/poetry

It is proposed that in this setting we have an insufficient path to identify the existence of the legacy Poetry version and thus skip entirely running its uninstaller.

[phillxnet]

The essensence here is:

which: no poetry in (/usr/local/bin:/opt/rockstor/.venv/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)

and:

• removes our legacy Poetry 1.1.15, installed (in /root/.local/bin/) via upstream installer script,

This is suspected as only affect "Build on ..." 15.4 base OS installs.

[phillxnet]

Noteworthy here is our existing explicit addition of the required path during/in our existing %build scriptlet:

https://github.com/rockstor/rockstor-rpmbuild/blob/983aaef3e6cdc041c7a6433dccd0290321613c12/rockstor.spec#L230

[phillxnet]

Closing as:
Fixed by #2784