Failure to remove legacy poetry version in 5.0.6-0 rpm #2782 #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add legacy poetry install path to avoid failing its uninstall. Without this additional path, when build.sh is run from within RPM's constrained %posttrans scriptlet, we fail to find and uninstall our prior 1.1.15 poetry version. This leads to having both poetry 1.1.15 (via upstream installer) and our new pipx installed poetry 1.7.1. ## Includes: - Remove dangling legacy poetry symlink - apparently neglected by legacy poetry installer/uninstaller. - After the above there is an in-memory 'poetry' resolution to `/root/.local/bin/poetry' until path is reset. So use reset as opportunity to remove legacy path. - Add echo of PATH used by remainder of build.sh. - Remove .venv related path from PATH as the entire directory is deleted in the %post RPM scriptlet. And build.sh (outside of development) is run after this: from %posttrans.
|
@FroggyFlox & @Hooverdan96 We have more work to do in this area: but that is never news :). |
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add legacy poetry install path to avoid failing its uninstall. Without this additional path, when build.sh is run from within RPM's constrained %posttrans scriptlet, we fail to find and uninstall our prior 1.1.15 poetry version. This leads to having both poetry 1.1.15 (via upstream installer) and our new pipx installed poetry 1.7.1.
Includes:
Testing
See the following comment in this PR's draft predecessor:
#2783 (comment)
Fixes #2782
In that we now remove the legacy Poetry, where-as previously, the mechanism to update Poetry introduced in rpm 5.0.6-0 failed in this regard. This did no show-up in development as we prove each testing rpm's install (not update) capability on the build host, and in our rpm %build scriptlet the required legacy poetry path was established before hand.