Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Poetry re rpmbuild & normalise on Python 3.11 #50

Closed
phillxnet opened this issue Oct 15, 2023 · 3 comments
Closed

Update Poetry re rpmbuild & normalise on Python 3.11 #50

phillxnet opened this issue Oct 15, 2023 · 3 comments
Assignees
@phillxnet

Comments

@phillxnet
Copy link
Member

phillxnet commented Oct 15, 2023 •
edited
Loading

During the RPM %build & %check scriptlets we instantiation and use a Poetry install. Ensure the Poerty version used is in-step with changes implemented in rocksot-core against the following issue:
"Update Poetry build system": rockstor/rockstor-core#2703

See the above linked issue for caveates relating to our current use of the now out-dated 1.1.x series of Poetry.
@phillxnet
Copy link
Member Author

Given the following comment in this issues above referenced counterpart:
rockstor/rockstor-core#2703 (comment)

We need to ensure that our build requirements include the Python version we intend to use to install Poetry itself.
As we install our expected Poetry version within the %build scriptlet.

@phillxnet
Copy link
Member Author

A further proposal here is that we remove the Poetry install from the %build script entirely. As per other 'build' tools it could easily be a requirement, but likely not a hard package requirement, but details as required within our docs. This way we remove the dual source of truth re Poetry install (rockstor-core's build.sh) & (rockstor-rpmbuild %build scriptlet).

However, we would then face difficulties regarding builds on the same host for both testing and stable - where the python version or Specified Poetry version may differ.

@phillxnet phillxnet self-assigned this Nov 22, 2023
@phillxnet phillxnet changed the title Update Poetry install used to execute our tests Update Poetry install used during rpmbuild Nov 23, 2023
@phillxnet phillxnet mentioned this issue Nov 23, 2023
Merged
@phillxnet phillxnet changed the title Update Poetry install used during rpmbuild Update Poetry re rpmbuild & normalise on Python 3.11 Nov 23, 2023
phillxnet added a commit to phillxnet/rockstor-rpmbuild that referenced this issue Nov 23, 2023
@phillxnet
Update Poetry re rpmbuild & normalise on Python 3.11 rockstor#50
14c902e 
Align with rockstor-core `build.sh` re Poetry update and
install via OS provided pipx under Python 3.11.
## Includes
- Path changes regarding new Poetry install location.
- All targets move from Python 3.9 to Python 3.11.
- Additional python311-pipx BuildRequires and Requires.
- Additional update-alternatives to enforce Py3.11 pipx.
@phillxnet phillxnet mentioned this issue Nov 23, 2023
Merged
phillxnet added a commit that referenced this issue Nov 24, 2023
@phillxnet
Merge pull request #52 from phillxnet/50-Update-Poetry-re-rpmbuild-&-…
d6b0d84 
…normalise-on-Python-3.11

Update Poetry re rpmbuild & normalise on Python 3.11 #50
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillxnet