Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iDynTree PyPI binary packaging: Migrate from manylinux_2_24 to manylinux_2_28 and disable IDYNTREE_USES_IPOPT DIDYNTREE_USES_ASSIMP:BOOL IDYNTREE_USES_IRRLICHT options on PyPI #1068

Merged
merged 5 commits into from
May 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ jobs:
env:
CIBW_BUILD_VERBOSITY: 1
CIBW_BUILD: cp37-*manylinux*_x86_64 cp38-*manylinux*_x86_64 cp39-*manylinux*_x86_64 cp310-*manylinux*_x86_64
CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_24
CIBW_ENVIRONMENT_LINUX: AUDITWHEEL_PLAT=manylinux_2_24_x86_64
CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_28
CIBW_ENVIRONMENT_LINUX: AUDITWHEEL_PLAT=manylinux_2_28_x86_64
CIBW_BEFORE_BUILD_LINUX: |
apt-get update &&\
apt-get install -y libeigen3-dev libassimp-dev libxml2-dev coinor-libipopt-dev libirrlicht-dev
dnf update -y &&\
dnf install -y eigen3-devel libxml2-devel
CIBW_TEST_COMMAND: "python -c 'import idyntree.bindings'"

- uses: actions/upload-artifact@v3
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Binary wheels available on PyPI now target `manylinux_2_28`, and the options `IDYNTREE_USES_ASSIMP`, `IDYNTREE_USES_IPOPT` and `IDYNTREE_USES_IRRLICHT` are disable in binary wheels on PyPI. If you need these options enabled, please use conda-forge binaries or build iDynTree from source (https://github.com/robotology/idyntree/pull/1068).
- Use iDynTree::InverseKinematicsRotationParametrizationRollPitchYaw as default parametrization in iDynTree::InverseKinematics (https://github.com/robotology/idyntree/pull/1058).

#### URDF XML parser change
Expand Down
6 changes: 3 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
"-DIDYNTREE_USES_PYTHON:BOOL=ON",
"-DIDYNTREE_COMPILE_TESTS:BOOL=OFF",
"-DIDYNTREE_PACKAGE_FOR_PYPI:BOOL=ON",
"-DIDYNTREE_USES_IPOPT:BOOL=ON",
"-DIDYNTREE_USES_ASSIMP:BOOL=ON",
"-DIDYNTREE_USES_IRRLICHT:BOOL=ON",
"-DIDYNTREE_USES_IPOPT:BOOL=OFF",
"-DIDYNTREE_USES_ASSIMP:BOOL=OFF",
"-DIDYNTREE_USES_IRRLICHT:BOOL=OFF",
"-DIDYNTREE_USES_OSQPEIGEN:BOOL=OFF",
"-DIDYNTREE_USES_ALGLIB:BOOL=OFF",
"-DIDYNTREE_USES_WORHP:BOOL=OFF",
Expand Down