-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iDynTree PyPI binary packaging: Migrate from manylinux_2_24 to manylinux_2_28 and disable IDYNTREE_USES_IPOPT DIDYNTREE_USES_ASSIMP:BOOL IDYNTREE_USES_IRRLICHT options on PyPI #1068
Conversation
…nux_2_28 manylinux_2_24 was EOL since the beginnng of 2023: pypa/manylinux#1369 .
Apparently |
At a first glance, almalinux does not have assimp, irrlicht and ipopt packages, while it has eigen and libxml2 . Probably we can wait for @diegoferigo to be back to discuss the way forward here. At a first glance options are:
|
The PyPI wheels seem to me quite effortless to maintain. Rather than removing the support of the wheels entirely, I'd proceed with just If anyone needs features based on The only feature that could be missed is the NLP IK that is based on ipopt. Maybe this can be addressed using coin-or/coinbrew that might simplify building everything from sources. |
@traversaro you should also update the following options: Lines 18 to 32 in e555c58
|
Thanks, done in 4378bbe . |
Ok, the PR is ready for review and for now we disable ipopt, assimp and irrlicht support in binary wheels. Contributition to enable back (and mantain) the support for them is welcome if anyone needs such support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @traversaro!
Fix #1067 .
manylinux_2_24 was EOL since the beginnng of 2023: pypa/manylinux#1369 .