Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace null-cap CSR reset values with a tag clear (fixes issue 43) #101

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

tariqkurd-repo
Copy link
Collaborator

@tariqkurd-repo tariqkurd-repo commented Feb 9, 2024

All CSRs which used to reset to NULL_CAP now just have a tag clear with unspecified data.
All CSRs which reset to infinity are unchanged

@arichardson arichardson linked an issue Feb 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. @jrtc27 @sorear do you agree?

Commit message should include "Fixes #43"?

@sorear
Copy link
Contributor

sorear commented Feb 10, 2024

I think that we will eventually need an ARC position on whether "reset values" apply before or after the execution of an implementation-dependent BootROM and where the appropriate place for compatibility requirements is.

Within the assumptions that have been made previously on this tracker, LGTM.

@tariqkurd-repo tariqkurd-repo changed the title replace null-cap CSR reset values with a tag clear replace null-cap CSR reset values with a tag clear (fixes issue 43) Feb 12, 2024
@arichardson arichardson merged commit 4a8337b into riscv:main Feb 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset values of capability CSRs
4 participants