Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all completable journal entries to have a failure variant #58

Closed
tillrohrmann opened this issue Dec 16, 2023 · 0 comments · Fixed by #59
Closed

Allow all completable journal entries to have a failure variant #58

tillrohrmann opened this issue Dec 16, 2023 · 0 comments · Fixed by #59
Assignees
@tillrohrmann

Comments

@tillrohrmann
Copy link
Contributor

In order to support cancellations, it would be great if all completable journal entries would have a failure variant that they support.
@tillrohrmann tillrohrmann self-assigned this Dec 16, 2023
tillrohrmann added a commit to tillrohrmann/service-protocol that referenced this issue Dec 17, 2023
@tillrohrmann
Extend GetState, PollInputStream and SleeEntryMessage with failure va…
476c686 
…riants

This fixes restatedev#58.
This was referenced Dec 17, 2023
Merged
Closed
Closed
This was referenced Dec 17, 2023
Closed
Merged
tillrohrmann added a commit to tillrohrmann/sdk-java that referenced this issue Dec 18, 2023
@tillrohrmann
Update SDK to use restatedev/service-protocol#58
b9356db 
This commit updates the Java SDK to allow all completable journal entries
to have a failure variant. As part of this change, we also added tests to
ensure the correct behavior.

This fixes restatedev#187.
tillrohrmann added a commit to tillrohrmann/sdk-java that referenced this issue Dec 18, 2023
@tillrohrmann
fixup! Update SDK to use restatedev/service-protocol#58
aaa6cfa
tillrohrmann added a commit to tillrohrmann/sdk-java that referenced this issue Dec 18, 2023
@tillrohrmann
Update SDK to use restatedev/service-protocol#58
1894ec5 
This commit updates the Java SDK to allow all completable journal entries
to have a failure variant. As part of this change, we also added tests to
ensure the correct behavior.

This fixes restatedev#187.
tillrohrmann added a commit to tillrohrmann/sdk-java that referenced this issue Dec 18, 2023
@tillrohrmann
fixup! Update SDK to use restatedev/service-protocol#58
4f5a2c1
tillrohrmann added a commit to tillrohrmann/sdk-java that referenced this issue Dec 18, 2023
@tillrohrmann
Update SDK to use restatedev/service-protocol#58
f1dd357 
This commit updates the Java SDK to allow all completable journal entries
to have a failure variant. As part of this change, we also added tests to
ensure the correct behavior.

This fixes restatedev#187.
tillrohrmann added a commit to tillrohrmann/sdk-java that referenced this issue Dec 19, 2023
@tillrohrmann
Update SDK to use restatedev/service-protocol#58
e06cc00 
This commit updates the Java SDK to allow all completable journal entries
to have a failure variant. As part of this change, we also added tests to
ensure the correct behavior.

This fixes restatedev#187.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tillrohrmann tillrohrmann

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tillrohrmann