Update server to work with new service protocol contract #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2023
slinkydeveloper
requested changes
Dec 18, 2023
adad69d to
7012a94
Compare
|
I've addressed your comments @slinkydeveloper. PTAL. |
slinkydeveloper
approved these changes
Dec 18, 2023
|
Thanks for the review @slinkydeveloper. Merging this PR now. |
…c66ea..185da8bd 185da8bd Extend GetState, PollInputStream and SleeEntryMessage with failure variants git-subtree-dir: crates/service-protocol/service-protocol git-subtree-split: 185da8bd37c9e606cc2853623278f5b499e7c7b1
This commit pulls in the latest service protocol changes. It updates the server to handle GetState, Sleep and PollInputStreamEntryMessage as fallible (having an error case). This fixes restatedev#999.
7012a94 to
0a87fe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires restatedev/service-protocol#58 to be merged first.
This commit pulls in the latest service protocol changes.
It updates the server to handle GetState, Sleep and
PollInputStreamEntryMessage as fallible (having an error case).
This fixes #999.