Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend GetState, PollInputStream and SleeEntryMessage with failure variants #59

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Extend GetState, PollInputStream and SleeEntryMessage with failure variants #59

merged 1 commit into from
Dec 18, 2023

Conversation

tillrohrmann
Copy link
Contributor

This fixes #58.

slinkydeveloper
slinkydeveloper requested changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the text here https://github.com/restatedev/service-protocol/blob/main/service-invocation-protocol.md#journal-entries-reference as well.

@tillrohrmann tillrohrmann mentioned this pull request Dec 18, 2023
Merged
@tillrohrmann
Copy link
Contributor Author

Thanks for the review @slinkydeveloper. Merging this PR now.

@tillrohrmann tillrohrmann merged commit 185da8b into restatedev:main Dec 18, 2023
1 check passed
@tillrohrmann tillrohrmann deleted the issues/58 branch December 18, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow all completable journal entries to have a failure variant
2 participants
@tillrohrmann @slinkydeveloper