-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-react): fix fetcher.formEncType
#6807
Conversation
|
Hi @AlemTuzlak, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Thank you! Since this contains code changes, would you mind repointing to |
@brophdawg11 will do! |
fetcher.formEncType
closing in favor of #6810 |
I believe that there is a typing issue with fetchers where the encType is not typed correctly, I noticed this when using useNavigate where the hook was typed but the fetcher wasn't so I tracked it down and fixed it.
Testing Strategy:
useFetcher
oruseFetchers
FormEncType | undefined
instead ofstring | undefined