Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(other-api/dev-v2): avoid ghost value creation #6756

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

edzis
Copy link
Contributor

@edzis edzis commented Jul 2, 2023

Closes #6754

@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2023

⚠️ No Changeset found

Latest commit: 6895b33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 2, 2023

Hi @edzis,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 2, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@edzis edzis changed the title Avoid ghost value creation when using app/utils/remember.ts fix(docs): Avoid ghost value creation when using app/utils/remember.ts Jul 2, 2023
@pcattori pcattori merged commit 6dd3a20 into remix-run:main Jul 3, 2023
@MichaelDeBoey MichaelDeBoey changed the title fix(docs): Avoid ghost value creation when using app/utils/remember.ts docs(other-api/dev-v2): avoid ghost value creation Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app/utils/remember.ts causes creation of ghost values
3 participants