Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates(arc): propagate NODE_ENV to application in arc sandbox mode #6757

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Jul 2, 2023

Fixes #198.

Testing Strategy:

I ran npx create-remix@latest, created a new Architect project, and ran npm run dev. I opened a browser, turned on developer tools, and showed the JavaScript console. Here are screen shots before and after this patch, showing that the #198 is fixed.

Before

Screenshot 2023-07-02 at 10 31 54

After

Screenshot 2023-07-02 at 10 32 19

@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2023

⚠️ No Changeset found

Latest commit: 9f7cf10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori
Copy link
Contributor

pcattori commented Jul 5, 2023

@lpsinger since this PR only makes changes to templates, can you rebase on main? That way we can get this out to users without waiting for the next Remix release

@lpsinger lpsinger force-pushed the fix-arc-node-env branch from 62358ff to 9f7cf10 Compare July 5, 2023 19:15
@lpsinger lpsinger changed the base branch from dev to main July 5, 2023 19:15
@lpsinger
Copy link
Contributor Author

lpsinger commented Jul 5, 2023

@lpsinger since this PR only makes changes to templates, can you rebase on main? That way we can get this out to users without waiting for the next Remix release

Done.

@pcattori pcattori self-assigned this Jul 5, 2023
@pcattori pcattori merged commit 7cab60f into remix-run:main Jul 5, 2023
@MichaelDeBoey MichaelDeBoey changed the title fix: propagate NODE_ENV to application in arc sandbox mode templates(arc): propagate NODE_ENV to application in arc sandbox mode Jul 5, 2023
@lpsinger lpsinger deleted the fix-arc-node-env branch July 5, 2023 21:52
@lpsinger
Copy link
Contributor Author

lpsinger commented Jul 6, 2023

I don't know how it works, do you need to cherry-pick this onto the dev branch now?

@pcattori
Copy link
Contributor

pcattori commented Jul 6, 2023

I don't know how it works, do you need to cherry-pick this onto the dev branch now?

Nope, dev can have stale templates. When we do a release we'll sync up dev and main, which will pick up the changes in main. No action needed on your part.

lpsinger added a commit to lpsinger/remix that referenced this pull request Jul 8, 2023
Thanks to remix-run#6757 and remix-run#6781, these are no longer needed.
lpsinger added a commit to lpsinger/remix that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on entry.client when starting a new project using arc
3 participants