-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templates(arc): propagate NODE_ENV
to application in arc sandbox mode
#6757
Conversation
|
@lpsinger since this PR only makes changes to templates, can you rebase on |
62358ff
to
9f7cf10
Compare
Done. |
NODE_ENV
to application in arc sandbox mode
I don't know how it works, do you need to cherry-pick this onto the |
Nope, |
Thanks to remix-run#6757 and remix-run#6781, these are no longer needed.
Thanks to remix-run#6757 and remix-run#6781, these are no longer needed. See remix-run/grunge-stack#154 (comment).
Fixes #198.
Testing Strategy:
I ran
npx create-remix@latest
, created a new Architect project, and rannpm run dev
. I opened a browser, turned on developer tools, and showed the JavaScript console. Here are screen shots before and after this patch, showing that the #198 is fixed.Before
After