ci(Mergify): configuration update #221
Conversation
Signed-off-by: DraugSköll <kprinny@gmail.com>
|
Deployment failed with the following error: |
|
Deployment failed with the following error: |
|
Review changes with |
|
Aviator Changeset actions:
|
|
PR has been added to the changeset: 2: https://app.aviator.co/changeset/2 |
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time. Change Sets
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
|
Deployment failed with the following error: |
|
Please follow naming conventions! 😿 |
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Przewodnik Recenzenta przez SourceryTen pull request aktualizuje konfigurację Mergify, aby oznaczyć pull requesty, które są częścią stosu Mergify, oraz usuwa regułę priorytetu dla threattrix. Diagram przepływu zaktualizowanego przetwarzania PR Mergifyflowchart TD
PR[Nowy Pull Request] --> CheckCommit{Sprawdź pierwszą wiadomość commit}
CheckCommit -->|Zawiera 'Change-Id:'| AddLabel[Dodaj etykietę 'stack']
CheckCommit -->|Brak 'Change-Id:'| SkipLabel[Pomiń etykietowanie]
AddLabel --> AutoMergeCheck{Sprawdź warunki automerge}
SkipLabel --> AutoMergeCheck
AutoMergeCheck -->|Warunki spełnione| Merge[Scal PR]
AutoMergeCheck -->|Warunki niespełnione| Wait[Czekaj na warunki]
Zmiany na Poziomie Plików
Porady i poleceniaInterakcja z Sourcery
Dostosowywanie Twojego DoświadczeniaUzyskaj dostęp do pulpitu nawigacyjnego, aby:
Uzyskiwanie Pomocy
Original review guide in EnglishReviewer's Guide by SourceryThis pull request updates the Mergify configuration to label pull requests that are part of a Mergify stack and removes the priority rule for threattrix. Flow diagram of updated Mergify PR processingflowchart TD
PR[New Pull Request] --> CheckCommit{Check first commit message}
CheckCommit -->|Contains 'Change-Id:'| AddLabel[Add 'stack' label]
CheckCommit -->|No 'Change-Id:'| SkipLabel[Skip labeling]
AddLabel --> AutoMergeCheck{Check automerge conditions}
SkipLabel --> AutoMergeCheck
AutoMergeCheck -->|Conditions met| Merge[Merge PR]
AutoMergeCheck -->|Conditions not met| Wait[Wait for conditions]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Here's the code health analysis summary for commits Analysis Summary
|
|
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Do not merge outdated PRsWonderful, this rule succeeded.Make sure PRs are almost up to date before merging
|
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 200bb1a |
There was a problem hiding this comment.
Cześć @reisene - przejrzałem Twoje zmiany i wyglądają świetnie!\n\n
Oto, co sprawdziłem podczas przeglądu
\n\n- 🟡 Problemy ogólne: znaleziono 1 problem\n- 🟢 Bezpieczeństwo: wszystko wygląda dobrze\n- 🟢 Testy: wszystko wygląda dobrze\n- 🟢 Złożoność: wszystko wygląda dobrze\n- 🟢 Dokumentacja: wszystko wygląda dobrze\nSourcery jest darmowy dla projektów open source - jeśli podobają Ci się nasze recenzje, rozważ ich udostępnienie ✨
\n\n- X\n- Mastodon\n- LinkedIn\n- Facebook\n\nOriginal comment in English
Hey @reisene - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| - name: Label Mergify Stacks PRs | ||
| description: Pull requests that are part of a Mergify stack should be labeled as such | ||
| conditions: | ||
| - "commits[0].commit_message ~= (?m)Change-Id:" |
There was a problem hiding this comment.
sugestia: Rozważ sprawdzenie Change-Id we wszystkich commitach, a nie tylko w pierwszym
Użycie 'commits[].commit_message' zamiast 'commits[0].commit_message' zapewniłoby wykrycie stosu nawet wtedy, gdy Change-Id pojawia się w późniejszych commitach stosu.
| - "commits[0].commit_message ~= (?m)Change-Id:" | |
| - "commits[].commit_message ~= (?m)Change-Id:" |
Original comment in English
suggestion: Consider checking all commits for Change-Id instead of just the first one
Using 'commits[].commit_message' instead of 'commits[0].commit_message' would ensure the stack is detected even when the Change-Id appears in later commits of the stack.
| - "commits[0].commit_message ~= (?m)Change-Id:" | |
| - "commits[].commit_message ~= (?m)Change-Id:" |
|
Click here to review and test in web IDE: |
|
Skipping bot pull request creation because the queue is empty and this pull request is up to date with |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
|
This pull request has been removed from the queue for the following reason: Pull request #221 has been dequeued. Pull request automatically merged by a You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
Hey @reisene, your pull request has been dequeued due to the following reason: PR_DEQUEUED. |
This change has been made by @reisene from the Mergify workflow automation editor.
Podsumowanie przez Sourcery
Usunięcie reguły priorytetu
threattrixi dodanie etykiety dla PR-ów ze stosu Mergify.CI:
threattrix.Original summary in English
Summary by Sourcery
Remove the
threattrixpriority rule and add a label for Mergify stack PRs.CI:
threattrixhigh priority merge rule.