Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(Mergify): configuration update #221

Merged
merged 1 commit into from
Jan 15, 2025
Merged

ci(Mergify): configuration update #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .mergify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
pull_request_rules:
- name: Label Mergify Stacks PRs
description: Pull requests that are part of a Mergify stack should be labeled as such
conditions:
- "commits[0].commit_message ~= (?m)Change-Id:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sugestia: Rozważ sprawdzenie Change-Id we wszystkich commitach, a nie tylko w pierwszym

Użycie 'commits[].commit_message' zamiast 'commits[0].commit_message' zapewniłoby wykrycie stosu nawet wtedy, gdy Change-Id pojawia się w późniejszych commitach stosu.

Suggested change
- "commits[0].commit_message ~= (?m)Change-Id:"
- "commits[].commit_message ~= (?m)Change-Id:"
Original comment in English

suggestion: Consider checking all commits for Change-Id instead of just the first one

Using 'commits[].commit_message' instead of 'commits[0].commit_message' would ensure the stack is detected even when the Change-Id appears in later commits of the stack.

Suggested change
- "commits[0].commit_message ~= (?m)Change-Id:"
- "commits[].commit_message ~= (?m)Change-Id:"

actions:
label:
toggle:
- stack
- name: Automatic merge
description: Merge when PR passes all branch protection and has label automerge
conditions:
Expand Down Expand Up @@ -70,11 +78,3 @@ merge_protections:
queue_rules: []
merge_queue:
max_parallel_checks: 5
priority_rules:
- name: threattrix
priority: high
conditions:
- head = trx
- and:
- base = main
allow_checks_interruption: true
Loading