Backport some of the changes from master to 2.8 #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the `poetry install` command fails, we probably don't want to continue in the execution anymore, so let's have a fail fast check there. (cherry picked from commit ea67c95)
We are trying to retrieve the ID of the cluster that OCM uses for its work. For this we use either the cluster name or the cluster ID (different ID to the one that OCM uses). The cluster ID is saved in the external_id key. Also, to keep this function reflexive, let's keep also `id` in the query too. With this, we can always call this function and get the ocm ID for the cluster anytime we use cluster `name`, `external ID` or `ID`. (cherry picked from commit 2ab713a)
The original `qaprodauth.console.redhat.com` has been moved to `console.dev.redhat.com`. Also changed variable names to uppercase since these are the section variables. (cherry picked from commit 1af11d2)
During our global move to PatternFly 5 changes in Dashboard, we probably accidentally changed also selector for the OCM login page, which still uses older version obviously. On top of that I updated some other xpaths for the OCM and also amended the way how the Cookies settings modal window is being handled since it also seem to slightly different now. (cherry picked from commit d905c6f)
This isn't a complete complex update of all relevant tests, just a selected update. Minimum required changes were taken from [1,2]. [1] red-hat-data-services#1394 [2] red-hat-data-services#1312
|
| @@ -40,14 +40,14 @@ | |||
| END | |||
|
|
|||
| Maybe Accept Cookie Policy | |||
| ${cookie_required}= Run Keyword And Return Status Page Should Contain We use cookies on this site | |||
| ${cookie_required}= Run Keyword And Return Status Wait Until Page Contains Element | |||
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
Robot Results
|
0cdd34e
into
red-hat-data-services:releases/2.8.0
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the #1370 - this backports some that seem to be minimal effort and useful for the branch for the future:
poetry installcommand #1349CI: rhods-smoke/5317 - three failed tests passed on a re-run