Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Automation For Elyra Test in Dspv2 #1394

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Fixing Automation For Elyra Test in Dspv2 #1394

merged 5 commits into from
Apr 22, 2024

Conversation

Raghul-M
Copy link
Contributor

@Raghul-M Raghul-M commented Apr 18, 2024 •
edited by jgarciao
Loading

  • Fixes test suite 435__data-science-pipelines-elyra.robot to be simpler and work with DSPv2
  • Refactors test ODS-2271 to be Data-Driven using Robot Framework test templates (more info here)
  • Moves one Elyra test from Sanity to Smoke
  • Tested successfully in rhods-ci-pr-test/2711 (TensorFlow and HabanaAI failing reasons unrelated to this PR)

@Raghul-M Raghul-M added needs testing Needs to be tested in Jenkins do not merge Do not merge this yet please labels Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
450 0 0 450 100

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 19, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@jgarciao jgarciao force-pushed the Elyra-v2-modification branch from ffcfc12 to 6ea8263 Compare April 19, 2024 22:17
@jgarciao
Delete testing tag
72333d5 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@jgarciao jgarciao marked this pull request as ready for review April 19, 2024 22:20
@jgarciao jgarciao requested a review from diegolovison April 19, 2024 22:21
@jgarciao jgarciao added enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) and removed do not merge Do not merge this yet please labels Apr 19, 2024
@jgarciao
Add keyword teardown to stop the workbench
e95f2b7 
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jgarciao jgarciao added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Apr 20, 2024
@jgarciao jgarciao requested a review from asanzgom April 22, 2024 08:36
@jgarciao jgarciao merged commit 8a22216 into red-hat-data-services:master Apr 22, 2024
8 checks passed
@jstourac jstourac mentioned this pull request Apr 25, 2024
Open
jstourac added a commit to jstourac/ods-ci that referenced this pull request May 3, 2024
@jstourac
Update DSP elyra tests
576c360 
This isn't a complete complex update of all relevant tests, just a
selected update. Minimum required changes were taken from [1,2].

[1] red-hat-data-services#1394
[2] red-hat-data-services#1312
@jstourac jstourac mentioned this pull request May 3, 2024
Merged
jstourac added a commit that referenced this pull request May 4, 2024
@jstourac
Update DSP elyra tests
0cdd34e 
This isn't a complete complex update of all relevant tests, just a
selected update. Minimum required changes were taken from [1,2].

[1] #1394
[2] #1312
@Raghul-M Raghul-M deleted the Elyra-v2-modification branch August 12, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asanzgom asanzgom asanzgom approved these changes

@jstourac jstourac jstourac approved these changes

@diegolovison diegolovison Awaiting requested review from diegolovison

@manosnoam manosnoam Awaiting requested review from manosnoam

@jiridanek jiridanek Awaiting requested review from jiridanek

Assignees
No one assigned
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Raghul-M @jstourac @asanzgom @jgarciao