Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pipelines tests to DSPv2 (pipelines-api, pipelines-kfp) #1312

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

diegolovison
Copy link
Contributor

@diegolovison diegolovison commented Mar 20, 2024

Dispite of ray integration tests the others looks good

sh ods_ci/run_robot_test.sh --set-urls-variables true --extra-robot-args '-L DEBUG' --test-case 'ods_ci/tests/Tests/400__ods_dashboard/430__data_science_pipelines/431__data-science-pipelines-api.robot' --skip-oclogin
sh ods_ci/run_robot_test.sh --set-urls-variables true --extra-robot-args '-L DEBUG' --test-case 'ods_ci/tests/Tests/400__ods_dashboard/430__data_science_pipelines/432__data-science-pipelines-kfp.robot' --skip-oclogin

response = requests.get(url, headers=headers, verify=self.get_cert())
def do_get(self, url, headers=None, skip_ssl=False):
if skip_ssl:
response = requests.get(url, headers=headers, verify=False)

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections High

Enable server certificate validation on this SSL/TLS connection. See more on SonarCloud
@@ -65,14 +63,13 @@
Remove Pipeline Project ${project}
New Project ${project}
Install DataSciencePipelinesApplication CR ${project}
${status} Login And Wait Dsp Route ${username} ${password} ${project} ds-pipeline-pipelines-definition
${status} Login And Wait Dsp Route ${username} ${password} ${project}

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected ' =' but got '' instead
Should Be True ${run_status} Pipeline run doesn't have a status that means success. Check the logs
DataSciencePipelinesAPI.Delete Runs ${run_id}
DataSciencePipelinesAPI.Delete Pipeline ${pipeline_id}
Should Be Equal As Strings ${run_status} SUCCEEDED Pipeline run doesn't have a status that means success. Check the logs

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (133/120)
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
447 0 0 447 100

... username=${TEST_USER.USERNAME}
... password=${TEST_USER.PASSWORD}
... project=${PROJECT_NAME}
... python_file=flip_coin.py
... method_name=flipcoin_pipeline
... status_check_timeout=440
End To End Pipeline Workflow Using Kfp Tekton
${upload_download_dict}= Create Dictionary mlpipeline_minio_artifact_secret=value bucket_name=value

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected '' but got '=' instead
... username=${TEST_USER.USERNAME}
... password=${TEST_USER.PASSWORD}
... project=${PROJECT_NAME}
... python_file=flip_coin.py
... method_name=flipcoin_pipeline
... status_check_timeout=440
End To End Pipeline Workflow Using Kfp Tekton
${upload_download_dict}= Create Dictionary mlpipeline_minio_artifact_secret=value bucket_name=value

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create Dictionary can be replaced with VAR
${pipeline_id} Create Pipeline ${URL_TEST_PIPELINE_RUN_YAML}
${run_id} Create Run ${pipeline_id}
Setup Client ${username} ${password} ${project}
${pipeline_param}= Create Dictionary recipient=integration_test

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected ' =' but got '=' instead
${pipeline_id} Create Pipeline ${URL_TEST_PIPELINE_RUN_YAML}
${run_id} Create Run ${pipeline_id}
Setup Client ${username} ${password} ${project}
${pipeline_param}= Create Dictionary recipient=integration_test

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create Dictionary can be replaced with VAR
${run_id} Create Run ${pipeline_id}
Setup Client ${username} ${password} ${project}
${pipeline_param}= Create Dictionary recipient=integration_test
${run_id} Import Run Pipeline pipeline_url=${URL_TEST_PIPELINE_RUN_YAML} pipeline_params=${pipeline_param}

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected ' =' but got '' instead
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12 Security Hotspots
D Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint



*** Test Cases ***
Verify Ods Users Can Create And Run A Data Science Pipeline Using The kfp_tekton Python Package
Verify Ods Users Can Create And Run A Data Science Pipeline Using The kfp Python Package

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' is too long ({{ test_length }}/{{ allowed_length }}) Warning test

Test case 'Verify Ods Users Can Create And Run A Data Science Pipeline Using The kfp Python Package' is too long (22/20)
... ODS-2203
End To End Pipeline Workflow Using Kfp Tekton
[Tags] Sanity Tier1 ODS-2203
${emtpy_dict}= Create Dictionary

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected '' but got '=' instead
... ODS-2203
End To End Pipeline Workflow Using Kfp Tekton
[Tags] Sanity Tier1 ODS-2203
${emtpy_dict}= Create Dictionary

Check notice

Code scanning / Robocop

{{ create_keyword }} can be replaced with VAR Note test

Create Dictionary can be replaced with VAR
@diegolovison diegolovison marked this pull request as ready for review March 25, 2024 16:35
Copy link
Contributor

@jgarciao jgarciao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible that there are things to polish, but I think it's better to merge now and fix in follow-up PR, as we need this code for fixing other tests

@jgarciao jgarciao added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Mar 26, 2024
@jgarciao jgarciao changed the title Migrate to pipeline v2 Migrate to pipeline test to v2 (pipelines-api, pipelines-kfp) Mar 26, 2024
@jgarciao jgarciao changed the title Migrate to pipeline test to v2 (pipelines-api, pipelines-kfp) Migrate pipelines tests to DSPv2 (pipelines-api, pipelines-kfp) Mar 26, 2024
@jgarciao jgarciao requested a review from Raghul-M March 26, 2024 09:04
@jgarciao jgarciao merged commit 42741e8 into red-hat-data-services:master Mar 26, 2024
7 of 13 checks passed
jstourac added a commit to jstourac/ods-ci that referenced this pull request May 3, 2024
This isn't a complete complex update of all relevant tests, just a
selected update. Minimum required changes were taken from [1,2].

[1] red-hat-data-services#1394
[2] red-hat-data-services#1312
jstourac added a commit that referenced this pull request May 4, 2024
This isn't a complete complex update of all relevant tests, just a
selected update. Minimum required changes were taken from [1,2].

[1] #1394
[2] #1312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants