-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pipelines tests to DSPv2 (pipelines-api, pipelines-kfp) #1312
Conversation
response = requests.get(url, headers=headers, verify=self.get_cert()) | ||
def do_get(self, url, headers=None, skip_ssl=False): | ||
if skip_ssl: | ||
response = requests.get(url, headers=headers, verify=False) |
Check failure
Code scanning / SonarCloud
Server certificates should be verified during SSL/TLS connections High
@@ -65,14 +63,13 @@ | |||
Remove Pipeline Project ${project} | |||
New Project ${project} | |||
Install DataSciencePipelinesApplication CR ${project} | |||
${status} Login And Wait Dsp Route ${username} ${password} ${project} ds-pipeline-pipelines-definition | |||
${status} Login And Wait Dsp Route ${username} ${password} ${project} |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
...s/Tests/400__ods_dashboard/430__data_science_pipelines/431__data-science-pipelines-api.robot
Fixed
Show fixed
Hide fixed
Should Be True ${run_status} Pipeline run doesn't have a status that means success. Check the logs | ||
DataSciencePipelinesAPI.Delete Runs ${run_id} | ||
DataSciencePipelinesAPI.Delete Pipeline ${pipeline_id} | ||
Should Be Equal As Strings ${run_status} SUCCEEDED Pipeline run doesn't have a status that means success. Check the logs |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
... username=${TEST_USER.USERNAME} | ||
... password=${TEST_USER.PASSWORD} | ||
... project=${PROJECT_NAME} | ||
... python_file=flip_coin.py | ||
... method_name=flipcoin_pipeline | ||
... status_check_timeout=440 | ||
End To End Pipeline Workflow Using Kfp Tekton | ||
${upload_download_dict}= Create Dictionary mlpipeline_minio_artifact_secret=value bucket_name=value |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
... username=${TEST_USER.USERNAME} | ||
... password=${TEST_USER.PASSWORD} | ||
... project=${PROJECT_NAME} | ||
... python_file=flip_coin.py | ||
... method_name=flipcoin_pipeline | ||
... status_check_timeout=440 | ||
End To End Pipeline Workflow Using Kfp Tekton | ||
${upload_download_dict}= Create Dictionary mlpipeline_minio_artifact_secret=value bucket_name=value |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
${pipeline_id} Create Pipeline ${URL_TEST_PIPELINE_RUN_YAML} | ||
${run_id} Create Run ${pipeline_id} | ||
Setup Client ${username} ${password} ${project} | ||
${pipeline_param}= Create Dictionary recipient=integration_test |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
${pipeline_id} Create Pipeline ${URL_TEST_PIPELINE_RUN_YAML} | ||
${run_id} Create Run ${pipeline_id} | ||
Setup Client ${username} ${password} ${project} | ||
${pipeline_param}= Create Dictionary recipient=integration_test |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
${run_id} Create Run ${pipeline_id} | ||
Setup Client ${username} ${password} ${project} | ||
${pipeline_param}= Create Dictionary recipient=integration_test | ||
${run_id} Import Run Pipeline pipeline_url=${URL_TEST_PIPELINE_RUN_YAML} pipeline_params=${pipeline_param} |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
|
||
|
||
*** Test Cases *** | ||
Verify Ods Users Can Create And Run A Data Science Pipeline Using The kfp_tekton Python Package | ||
Verify Ods Users Can Create And Run A Data Science Pipeline Using The kfp Python Package |
Check warning
Code scanning / Robocop
Test case '{{ test_name }}' is too long ({{ test_length }}/{{ allowed_length }}) Warning test
... ODS-2203 | ||
End To End Pipeline Workflow Using Kfp Tekton | ||
[Tags] Sanity Tier1 ODS-2203 | ||
${emtpy_dict}= Create Dictionary |
Check warning
Code scanning / Robocop
The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test
... ODS-2203 | ||
End To End Pipeline Workflow Using Kfp Tekton | ||
[Tags] Sanity Tier1 ODS-2203 | ||
${emtpy_dict}= Create Dictionary |
Check notice
Code scanning / Robocop
{{ create_keyword }} can be replaced with VAR Note test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible that there are things to polish, but I think it's better to merge now and fix in follow-up PR, as we need this code for fixing other tests
This isn't a complete complex update of all relevant tests, just a selected update. Minimum required changes were taken from [1,2]. [1] red-hat-data-services#1394 [2] red-hat-data-services#1312
Dispite of
ray
integration tests the others looks good