Remove Modernizr, keep html5shiv #756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2019
Closed
|
Are there any updates on this? |
This was referenced Oct 24, 2019
Closed
|
This PR was broken after our move to Webpack. I've created #848 which does the same as this PR, but updated for the new build process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernizr has been part of the theme for a long time, although it is not used. Since it's presence has downsides (reflow on load, increased theme size), we want to remove it.
To keep backward compatibility with older IEs, I've kept html5shiv in this PR so there is less chance of breakage.
Fixes #724, #525. Related #414. Supersedes #624