Remove Modernizr #624
Remove Modernizr #624
Conversation
|
IE 10 on Windows 7 looks broken with and without Modernizr:
This is not visible on Microsofts Browser screenshot page. |
|
Microsoft has a great service for generating website screenshots with different browsers, including all IE versions since IE 8: https://developer.microsoft.com/en-us/microsoft-edge/tools/screenshots/ If you deploy your changes somewhere, it will be quite easy to see which browsers get broken. |
|
I know of that page (I even referenced it in the comment above) but it seems to produce some different results from actual tests on browsers. Since I don't know exactly how they are creating the screenshots, I prefer manual testing for such an important change. |
|
Oh, how could I not notice that link :) |
|
Hi just my 2¢ as the Modernizr module maintainer, you should definitely not hardcode Modernizr into your theme and instead provide any Modernizr tests you need using either a hook or theme.info entry. That way people can upgrade Modernizr on their own schedule, other modules can also control what tests are included, and you have less to maintain. |
|
@rupl thanks for commenting. I'm not sure how applicable your comment is, since sphinx_rtd_theme is not a Drupal theme, but a Sphinx theme. |
|
looooool sorry 😳 |
|
I think we should go forward with this. |
|
Closing in favor of #756 |
DO NOT MERGE YET
This PR removes Modernizr, as discussed in #525.
Behavior of non-evergreen browsers (mainly IE6 - IE11) needs to be verified, as this also removes the html5shiv that is incorporated in Modernizr. Possible effects may be incorrect rendering, buttons not working, navigation not functioning, JavaScript errors in console
This PR does not remove the rAF polyfill for old IE.