Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define browser support for the theme #786

Closed
agjohnson opened this issue Jul 19, 2019 · 4 comments
Closed

Define browser support for the theme #786

agjohnson opened this issue Jul 19, 2019 · 4 comments
Labels
Accepted Accepted issue on our roadmap Needed: design decision A core team decision is required

Comments

@agjohnson
Copy link
Collaborator

We don't explicitly define the theme supported browsers anywhere. RTD has been moving towards only supporting IE >= 11, and we haven't yet defined Android browser support.

We should communicate what we officially support, what the last version to support $BROWSER_VERSION was, and what we allow for degradation on unsupported browsers.

Unsupported browsers might include behaviors such as unsupported typefaces (minor), improper positioning of block level elements (medium impact), and I'm sure some old version have trouble display anything at all.

Changes that we've discussed in the past that would affect these browsers:

  • woff/woff2 font files only are not supported by IE < 9 or 10 and Android < 4.x. Both are small amounts of RTD annual traffic
  • Remove modernizer
  • etc
@agjohnson agjohnson added Needed: design decision A core team decision is required Accepted Accepted issue on our roadmap labels Jul 19, 2019
@jessetan
Copy link
Contributor

Modernizr can actually be removed for all browsers, since we do not use its feature detection. The only thing from Modernizr that is used by IE <11 is html5shiv. There is a PR that removes Modernizr but keeps html5shiv #756

@jessetan jessetan mentioned this issue Jul 20, 2019
@agjohnson
Copy link
Collaborator Author

We could also probably drop html5shiv if we want to limit our browser focus. If we want to remove html5shiv, we should discuss our position on supporting the older non IE browsers as well. Those versions are:

html5shiv provides basic HTML5 styling for Internet Explorer 6-9, Safari 4.x (and iPhone 3.x), and Firefox 3.x

@jessetan
Copy link
Contributor

html5shiv include is guarded by <!--[if lt IE 9]>, so it is not loaded for any other browser

@humitos
Copy link
Member

humitos commented Aug 12, 2024

We do have a list of supported browsers now at https://sphinx-rtd-theme.readthedocs.io/en/stable/development.html#supported-browsers

@humitos humitos closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

3 participants