Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyBindingMixins.OneWayBind shows a nullable warning when using a selector #2913

Closed
glennawatson opened this issue Aug 31, 2021 · 2 comments · Fixed by #2917 or #2925
Closed

PropertyBindingMixins.OneWayBind shows a nullable warning when using a selector #2913

glennawatson opened this issue Aug 31, 2021 · 2 comments · Fixed by #2917 or #2925

Comments

@glennawatson
Copy link
Contributor

Small bug in 16.2.1:
PropertyBindingMixins.OneWayBind shows a nullable warning when using a selector function and a vm property that is not marked nullable.

public static IReactiveBinding<TView, TOut> OneWayBind<TViewModel, TView, TProp, TOut>(this TView view, TViewModel? viewModel, Expression<Func<TViewModel, TProp?>> vmProperty, Expression<Func<TView, TOut>> viewProperty, Func<TProp?, TOut> selector)

I'm assuming you don't need ? for TProp

Originally posted by @HavenDV in #2912 (comment)

ChrisPulman added a commit that referenced this issue Sep 2, 2021
@ChrisPulman ChrisPulman mentioned this issue Sep 2, 2021
2 tasks
glennawatson pushed a commit that referenced this issue Sep 2, 2021
@HavenDV
Copy link
Contributor

HavenDV commented Sep 12, 2021

Seems PropertyBindingMixins are missed in PR because the problem still exists in 16.2.6.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants