Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [WPF] Problems with default ActivationForViewFetcher when upgrade from 13.3.2 to 14.1.1 #2912

Closed
HavenDV opened this issue Aug 31, 2021 · 4 comments
Labels

Comments

@HavenDV
Copy link
Contributor

HavenDV commented Aug 31, 2021

Describe the bug
In WPF, when creating any form, an exception is thrown in the constructor after calling the this.WhenActivated extension :
System.ArgumentException: 'Don't know how to detect when Dedoose.Views.MainView is activated/deactivated, you may need to implement IActivationForViewFetcher'
The same behavior is repeated when updating to the latest version 16.2.1

Screenshots
image

Environment

  • ReactiveUI Version: 14.1.1
@HavenDV HavenDV added the bug label Aug 31, 2021
@glennawatson
Copy link
Contributor

Question I assume you have the wpf nuget package installed.

@HavenDV
Copy link
Contributor Author

HavenDV commented Aug 31, 2021

Sorry, the problem is trivial - I updated the ReactiveUI for the main library and forgot to update for the WPF project.

@HavenDV HavenDV closed this as completed Aug 31, 2021
@HavenDV
Copy link
Contributor Author

HavenDV commented Aug 31, 2021

Small bug in 16.2.1:
PropertyBindingMixins.OneWayBind shows a nullable warning when using a selector function and a vm property that is not marked nullable.

public static IReactiveBinding<TView, TOut> OneWayBind<TViewModel, TView, TProp, TOut>(this TView view, TViewModel? viewModel, Expression<Func<TViewModel, TProp?>> vmProperty, Expression<Func<TView, TOut>> viewProperty, Func<TProp?, TOut> selector)

I'm assuming you don't need ? for TProp

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants