Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OneWayBind selector, rollback UNO version #2925

Merged
merged 2 commits into from
Sep 12, 2021
Merged

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

fix #2913
fix #2914

What is the current behaviour?

OneWayBind has a extension method with a nullable decorator on the selector reported to cause issues
UNO dev channel has linking issues in latest releases.

What is the new behaviour?

extension method OneWayBind with a nullable decorator on selector reverted
Rolling UNO back to last stable version

What might this PR break?

OneWayBind none expected
UNO if reliance on any new 3.0.10-devxxx channel features has been adopted a manual update to the dev version will be required

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #2925 (d4ddf42) into main (a869b29) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2925   +/-   ##
=======================================
  Coverage   72.18%   72.18%           
=======================================
  Files         140      140           
  Lines        4900     4900           
=======================================
  Hits         3537     3537           
  Misses       1363     1363           
Impacted Files Coverage Δ
...ctiveUI/Bindings/Property/PropertyBindingMixins.cs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a869b29...d4ddf42. Read the comment docs.

@glennawatson glennawatson merged commit 48e3156 into main Sep 12, 2021
@glennawatson glennawatson deleted the fix_2913_2914 branch September 12, 2021 13:23
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants