-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: gather ik failure information in IkReturn #985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns that do not output ikreturns
…tion/FindIKSolutions functions (WIP)
…o fill_vikreturns
…o fill_vikreturns
…into fill_vikreturns
19b1757
to
60c9232
Compare
sorry to bother you @ntohge, but do you know any progress on this pull request? |
…e set easily access interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a class
IkFailureInfo
that gathers additional information on reasons why an IK computation fails. For example, if an IK call finishes withIKRA_RejectJointLimits
, anikFailureInfo
instance will keep record of which robot configuration violates the limits.Changes
Added new classes
IkFailureInfo
: this stores information related to the failure such as robot configurations and ikparams.IkFailureAccumulator
: this stores caches ofIkFailureInfo
objects. When a valid pointer toIkFailureAccumulator
is given to aFindIKSolution
/FindIKSolutions
call, the ik solver can retrieveIkFailureInfo
from the accumulator, fill in related information, then store them in the outputIkReturn
. However, note that the implementation of filling failure information inIkFailureInfo
and henceIkReturn
is up to each ik solver.IkReturn
has a new member_vIkFailureInfos
that stores pointers toIkFailureInfo
s that are filled with failure information.PlannerStatus
can now also storeIkFailureInfo
s.Added/modified python bindings
FindIKSolution
andFindIKSolutions
calls from python can now accept an ik failure accumulator as an input. If an accumulator is provided to the call andikreturn=true
, then ik solver can fill in failure information and output them through the returnedIkReturn
.